Retain suggest docs stickyness with new editors

ramya-rao-a · ramya-rao-a · commit e692fc72c69e · 2017-06-28T12:19:01.000-07:00
diff --git a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
@@ -392,9 +392,12 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
 		this.isAuto = false;
 		this.focusedItem = null;
 		this.storageService = storageService;
-		this.storageService.store('expandSuggestionDocs', expandSuggestionDocsByDefault, StorageScope.GLOBAL);
-		if (this.storageService.get('expandSuggestionDocs', StorageScope.GLOBAL) === undefined) {
-			this.storageServiceAvailable = false;
+
+		if (this.expandDocsSettingFromStorage() === undefined) {
+			this.storageService.store('expandSuggestionDocs', expandSuggestionDocsByDefault, StorageScope.GLOBAL);
+			if (this.expandDocsSettingFromStorage() === undefined) {
+				this.storageServiceAvailable = false;
+			}
 		}
 
 		this.element = $('.editor-widget.suggest-widget');
@@ -1013,7 +1016,7 @@ export class SuggestWidget implements IContentWidget, IDelegate<ICompletionItem>
 	// Monaco Editor does not have a storage service
 	private expandDocsSettingFromStorage(): boolean {
 		if (this.storageServiceAvailable) {
-			return this.storageService.getBoolean('expandSuggestionDocs', StorageScope.GLOBAL, expandSuggestionDocsByDefault);
+			return this.storageService.getBoolean('expandSuggestionDocs', StorageScope.GLOBAL);
 		} else {
 			return this.expandSuggestionDocs;
 		}
