Remove some additional unused locals and write only members

mjbvz · mjbvz · commit e18ebff45a6b · 2017-11-07T11:24:55.000-08:00
diff --git a/src/vs/base/common/diff/diff2.ts b/src/vs/base/common/diff/diff2.ts
@@ -57,9 +57,6 @@ export class LcsDiff2 {
 	private ids_for_x: number[];
 	private ids_for_y: number[];
 
-	// @ts-ignore unused property
-	private hashFunc: IHashFunction;
-
 	private resultX: boolean[];
 	private resultY: boolean[];
 	private forwardPrev: number[];
@@ -73,14 +70,6 @@ export class LcsDiff2 {
 		this.ids_for_x = [];
 		this.ids_for_y = [];
 
-		if (hashFunc) {
-			this.hashFunc = hashFunc;
-		} else {
-			this.hashFunc = function (sequence, index) {
-				return sequence[index];
-			};
-		}
-
 		this.resultX = [];
 		this.resultY = [];
 		this.forwardPrev = [];
diff --git a/src/vs/editor/common/viewLayout/viewLineRenderer.ts b/src/vs/editor/common/viewLayout/viewLineRenderer.ts
@@ -618,22 +618,17 @@ function _renderLine(input: ResolvedRenderLineInput, sb: IStringBuilder): Render
 			{
 				let _charIndex = charIndex;
 				let _tabsCharDelta = tabsCharDelta;
-				// @ts-ignore unused local
-				let _charOffsetInPart = charOffsetInPart;
 
 				for (; _charIndex < partEndIndex; _charIndex++) {
 					const charCode = lineContent.charCodeAt(_charIndex);
 
 					if (charCode === CharCode.Tab) {
 						let insertSpacesCount = tabSize - (_charIndex + _tabsCharDelta) % tabSize;
 						_tabsCharDelta += insertSpacesCount - 1;
-						_charOffsetInPart += insertSpacesCount - 1;
 						partContentCnt += insertSpacesCount;
 					} else {
 						partContentCnt++;
 					}
-
-					_charOffsetInPart++;
 				}
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -618,22 +618,17 @@ function _renderLine(input: ResolvedRenderLineInput, sb: IStringBuilder): Render`
`618`	`618`	`{`
`619`	`619`	`let _charIndex = charIndex;`
`620`	`620`	`let _tabsCharDelta = tabsCharDelta;`
`621`		`- // @ts-ignore unused local`
`622`		`- let _charOffsetInPart = charOffsetInPart;`
`623`	`621`
`624`	`622`	`for (; _charIndex < partEndIndex; _charIndex++) {`
`625`	`623`	`const charCode = lineContent.charCodeAt(_charIndex);`
`626`	`624`
`627`	`625`	`if (charCode === CharCode.Tab) {`
`628`	`626`	`let insertSpacesCount = tabSize - (_charIndex + _tabsCharDelta) % tabSize;`
`629`	`627`	`_tabsCharDelta += insertSpacesCount - 1;`
`630`		`- _charOffsetInPart += insertSpacesCount - 1;`
`631`	`628`	`partContentCnt += insertSpacesCount;`
`632`	`629`	`} else {`
`633`	`630`	`partContentCnt++;`
`634`	`631`	`}`
`635`		`-`
`636`		`- _charOffsetInPart++;`
`637`	`632`	`}`
`638`	`633`	`}`
`639`	`634`