encoding - still ignore 'ascii'

Benjamin Pasero · Benjamin Pasero · commit ddfca307b1bd · 2019-11-12T18:48:27.000+01:00
diff --git a/src/vs/base/node/encoding.ts b/src/vs/base/node/encoding.ts
@@ -210,6 +210,17 @@ async function guessEncodingByBuffer(buffer: Buffer): Promise<string | null> {
 		return null;
 	}
 
+	// Ignore 'ascii' as guessed encoding because that
+	// is almost never what we want, rather fallback
+	// to the configured encoding then. Otherwise,
+	// opening a ascii-only file with auto guessing
+	// enabled will put the file into 'ascii' mode
+	// and thus typing any special characters is
+	// not possible anymore.
+	if (guessed.encoding.toLowerCase() === 'ascii') {
+		return null;
+	}
+
 	return toIconvLiteEncoding(guessed.encoding);
 }
 
diff --git a/src/vs/base/test/node/encoding/encoding.test.ts b/src/vs/base/test/node/encoding/encoding.test.ts
@@ -200,7 +200,7 @@ suite('Encoding', () => {
 		const file = getPathFromAmdModule(require, './fixtures/some_ansi.css');
 		const buffer = await readExactlyByFile(file, 512 * 8);
 		const mimes = await encoding.detectEncodingFromBuffer(buffer, true);
-		assert.equal(mimes.encoding, 'ascii');
+		assert.equal(mimes.encoding, null);
 	});
 
 	test('autoGuessEncoding (ShiftJIS)', async function () {
