fixes microsoft#45911

joaomoreno · joaomoreno · commit dafdde11c92f · 2018-03-28T09:56:58.000+02:00
diff --git a/extensions/git/src/model.ts b/extensions/git/src/model.ts
@@ -235,10 +235,9 @@ export class Model {
 			if (repository.submodules.length > submodulesLimit) {
 				window.showWarningMessage(localize('too many submodules', "The '{0}' repository has {1} submodules which won't be opened automatically. You can still open each one individually by opening a file within.", path.basename(repository.root), repository.submodules.length));
 				statusListener.dispose();
-				return;
 			}
 
-			this.scanSubmodules(repository);
+			this.scanSubmodules(repository, submodulesLimit);
 		};
 
 		const statusListener = repository.onDidRunGitStatus(checkForSubmodules);
@@ -260,7 +259,7 @@ export class Model {
 		this._onDidOpenRepository.fire(repository);
 	}
 
-	private scanSubmodules(repository: Repository): void {
+	private scanSubmodules(repository: Repository, limit: number): void {
 		const shouldScanSubmodules = workspace
 			.getConfiguration('git', Uri.file(repository.root))
 			.get<boolean>('detectSubmodules') === true;
@@ -270,6 +269,7 @@ export class Model {
 		}
 
 		repository.submodules
+			.slice(0, limit)
 			.map(r => path.join(repository.root, r.path))
 			.forEach(p => this.eventuallyScanPossibleGitRepository(p));
 	}

Original file line number	Diff line number	Diff line change
`@@ -235,10 +235,9 @@ export class Model {`
`235`	`235`	`if (repository.submodules.length > submodulesLimit) {`
`236`	`236`	`window.showWarningMessage(localize('too many submodules', "The '{0}' repository has {1} submodules which won't be opened automatically. You can still open each one individually by opening a file within.", path.basename(repository.root), repository.submodules.length));`
`237`	`237`	`statusListener.dispose();`
`238`		`- return;`
`239`	`238`	`}`
`240`	`239`
`241`		`- this.scanSubmodules(repository);`
	`240`	`+ this.scanSubmodules(repository, submodulesLimit);`
`242`	`241`	`};`
`243`	`242`
`244`	`243`	`const statusListener = repository.onDidRunGitStatus(checkForSubmodules);`
`@@ -260,7 +259,7 @@ export class Model {`
`260`	`259`	`this._onDidOpenRepository.fire(repository);`
`261`	`260`	`}`
`262`	`261`
`263`		`- private scanSubmodules(repository: Repository): void {`
	`262`	`+ private scanSubmodules(repository: Repository, limit: number): void {`
`264`	`263`	`const shouldScanSubmodules = workspace`
`265`	`264`	`.getConfiguration('git', Uri.file(repository.root))`
`266`	`265`	`.get<boolean>('detectSubmodules') === true;`
`@@ -270,6 +269,7 @@ export class Model {`
`270`	`269`	`}`
`271`	`270`
`272`	`271`	`repository.submodules`
	`272`	`+ .slice(0, limit)`
`273`	`273`	`.map(r => path.join(repository.root, r.path))`
`274`	`274`	`.forEach(p => this.eventuallyScanPossibleGitRepository(p));`
`275`	`275`	`}`