fix microsoft#43229

Benjamin Pasero · Benjamin Pasero · commit d5ef5acd056f · 2018-02-08T18:29:41.000+01:00
diff --git a/src/vs/base/browser/ui/list/listWidget.ts b/src/vs/base/browser/ui/list/listWidget.ts
@@ -364,8 +364,14 @@ const DefaultMultipleSelectionContoller = {
 };
 
 const DefaultOpenController = {
-	shouldOpen: (event: UIEvent) => true
-};
+	shouldOpen: (event: UIEvent) => {
+		if (event instanceof MouseEvent) {
+			return event.button === 0 /* left mouse button */ || event.button === 1 /* middle mouse button */;
+		}
+
+		return true;
+	}
+} as IOpenController;
 
 class MouseController<T> implements IDisposable {
 
diff --git a/src/vs/platform/list/browser/listService.ts b/src/vs/platform/list/browser/listService.ts
@@ -125,15 +125,18 @@ class MultipleSelectionController<T> implements IMultipleSelectionController<T>
 	}
 }
 
-class OpenController implements IOpenController {
+class WorkbenchOpenController implements IOpenController {
 
 	constructor(private configurationService: IConfigurationService) { }
 
 	shouldOpen(event: UIEvent): boolean {
 		if (event instanceof MouseEvent) {
 			const isDoubleClick = event.detail === 2;
+			if (!useSingleClickToOpen(this.configurationService) && !isDoubleClick) {
+				return false;
+			}
 
-			return useSingleClickToOpen(this.configurationService) || isDoubleClick;
+			return event.button === 0 /* left mouse button */ || event.button === 1 /* middle mouse button */;
 		}
 
 		return true;
@@ -145,7 +148,7 @@ function handleListControllers<T>(options: IListOptions<T>, configurationService
 		options.multipleSelectionController = new MultipleSelectionController(configurationService);
 	}
 
-	options.openController = new OpenController(configurationService);
+	options.openController = new WorkbenchOpenController(configurationService);
 
 	return options;
 }

Original file line number	Diff line number	Diff line change
`@@ -125,15 +125,18 @@ class MultipleSelectionController<T> implements IMultipleSelectionController<T>`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`
`128`		`-class OpenController implements IOpenController {`
	`128`	`+class WorkbenchOpenController implements IOpenController {`
`129`	`129`
`130`	`130`	`constructor(private configurationService: IConfigurationService) { }`
`131`	`131`
`132`	`132`	`shouldOpen(event: UIEvent): boolean {`
`133`	`133`	`if (event instanceof MouseEvent) {`
`134`	`134`	`const isDoubleClick = event.detail === 2;`
	`135`	`+ if (!useSingleClickToOpen(this.configurationService) && !isDoubleClick) {`
	`136`	`+ return false;`
	`137`	`+ }`
`135`	`138`
`136`		`- return useSingleClickToOpen(this.configurationService) \|\| isDoubleClick;`
	`139`	`+ return event.button === 0 /* left mouse button / \|\| event.button === 1 / middle mouse button */;`
`137`	`140`	`}`
`138`	`141`
`139`	`142`	`return true;`
`@@ -145,7 +148,7 @@ function handleListControllers<T>(options: IListOptions<T>, configurationService`
`145`	`148`	`options.multipleSelectionController = new MultipleSelectionController(configurationService);`
`146`	`149`	`}`
`147`	`150`
`148`		`- options.openController = new OpenController(configurationService);`
	`151`	`+ options.openController = new WorkbenchOpenController(configurationService);`
`149`	`152`
`150`	`153`	`return options;`
`151`	`154`	`}`