Skip to content

Commit cdfd6ec

Browse files
rebornixrebornix
committed
Merge remote-tracking branch 'origin/master' into rebornix/notebook
2 parents d256d56 + 2e1e484 commit cdfd6ec

280 files changed

Lines changed: 5855 additions & 3028 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@ about: Suggest an idea for this project
88
<!-- Please search existing issues to avoid creating duplicates. -->
99

1010
<!-- Describe the feature you'd like. -->
11+
<!-- Please include the latest version of VS Code you've confirmed to not have this feature -->

‎.github/commands.json‎

Lines changed: 167 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,167 @@
1+
[
2+
{
3+
"type": "comment",
4+
"name": "question",
5+
"allowUsers": [
6+
"cleidigh",
7+
"usernamehw",
8+
"gjsjohnmurray",
9+
"IllusionMH"
10+
],
11+
"action": "updateLabels",
12+
"addLabel": "*question"
13+
},
14+
{
15+
"type": "label",
16+
"name": "*question",
17+
"action": "close",
18+
"comment": "Please ask your question on [StackOverflow](https://aka.ms/vscodestackoverflow). We have a great community over [there](https://aka.ms/vscodestackoverflow). They have already answered thousands of questions and are happy to answer yours as well. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
19+
},
20+
{
21+
"type": "label",
22+
"name": "*dev-question",
23+
"action": "close",
24+
"comment": "We have a great developer community [over on slack](https://aka.ms/vscode-dev-community) where extension authors help each other. This is a great place for you to ask questions and find support.\n\nHappy Coding!"
25+
},
26+
{
27+
"type": "label",
28+
"name": "*extension-candidate",
29+
"action": "close",
30+
"comment": "We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the [VS Code Marketplace](https://aka.ms/vscodemarketplace). Just in case, in a few simple steps you can get started [writing your own extension](https://aka.ms/vscodewritingextensions). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
31+
},
32+
{
33+
"type": "label",
34+
"name": "*not-reproducible",
35+
"action": "close",
36+
"comment": "We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines might help you with that.\n\nHappy Coding!"
37+
},
38+
{
39+
"type": "label",
40+
"name": "*out-of-scope",
41+
"action": "close",
42+
"comment": "We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process [here](https://aka.ms/vscode-out-of-scope). If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.\n\nIf you wonder what we are up to, please see our [roadmap](https://aka.ms/vscoderoadmap) and [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nThanks for your understanding and happy coding!"
43+
},
44+
{
45+
"type": "comment",
46+
"name": "causedByExtension",
47+
"allowUsers": [
48+
"cleidigh",
49+
"usernamehw",
50+
"gjsjohnmurray",
51+
"IllusionMH"
52+
],
53+
"action": "updateLabels",
54+
"addLabel": "*caused-by-extension"
55+
},
56+
{
57+
"type": "label",
58+
"name": "*caused-by-extension",
59+
"action": "close",
60+
"comment": "This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the [marketplace](https://aka.ms/vscodemarketplace) for VS Code. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
61+
},
62+
{
63+
"type": "label",
64+
"name": "*as-designed",
65+
"action": "close",
66+
"comment": "The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
67+
},
68+
{
69+
"type": "label",
70+
"name": "*english-please",
71+
"action": "close",
72+
"comment": "This issue is being closed because its description is not in English, that makes it hard for us to work on it. Please open a new issue with an English description. You might find [Bing Translator](https://www.bing.com/translator) useful."
73+
},
74+
{
75+
"type": "comment",
76+
"name": "duplicate",
77+
"allowUsers": [
78+
"cleidigh",
79+
"usernamehw",
80+
"gjsjohnmurray",
81+
"IllusionMH"
82+
],
83+
"action": "updateLabels",
84+
"addLabel": "*duplicate"
85+
},
86+
{
87+
"type": "label",
88+
"name": "*duplicate",
89+
"action": "close",
90+
"comment": "Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues [here](https://aka.ms/vscodeissuesearch). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
91+
},
92+
{
93+
"type": "comment",
94+
"name": "confirm",
95+
"allowUsers": [
96+
"cleidigh",
97+
"usernamehw",
98+
"gjsjohnmurray",
99+
"IllusionMH"
100+
],
101+
"action": "updateLabels",
102+
"addLabel": "confirmed",
103+
"removeLabel": "confirmation-pending"
104+
},
105+
{
106+
"type": "comment",
107+
"name": "confirmationPending",
108+
"allowUsers": [
109+
"cleidigh",
110+
"usernamehw",
111+
"gjsjohnmurray",
112+
"IllusionMH"
113+
],
114+
"action": "updateLabels",
115+
"addLabel": "confirmation-pending",
116+
"removeLabel": "confirmed"
117+
},
118+
{
119+
"type": "comment",
120+
"name": "needsMoreInfo",
121+
"allowUsers": [
122+
"cleidigh",
123+
"usernamehw",
124+
"gjsjohnmurray",
125+
"IllusionMH"
126+
],
127+
"action": "updateLabels",
128+
"addLabel": "~needs more info"
129+
},
130+
{
131+
"type": "label",
132+
"name": "~needs version info",
133+
"action": "updateLabels",
134+
"addLabel": "needs more info",
135+
"removeLabel": "~needs version info",
136+
"comment": "Thanks for creating this issue! We figured it's missing some basic information, such as a version number, or in some other way doesn't follow our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines. Please take the time to review these and update the issue.\n\nHappy Coding!"
137+
},
138+
{
139+
"type": "label",
140+
"name": "~needs more info",
141+
"action": "updateLabels",
142+
"addLabel": "needs more info",
143+
"removeLabel": "~needs more info",
144+
"comment": "Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines. Please take the time to review these and update the issue.\n\nHappy Coding!"
145+
},
146+
{
147+
"type": "comment",
148+
"name": "a11ymas",
149+
"allowUsers": [
150+
"AccessibilityTestingTeam-TCS",
151+
"dixitsonali95",
152+
"Mohini78",
153+
"ChitrarupaSharma",
154+
"mspatil110",
155+
"umasarath52",
156+
"v-umnaik"
157+
],
158+
"action": "updateLabels",
159+
"addLabel": "a11ymas"
160+
},
161+
{
162+
"type": "label",
163+
"name": "*off-topic",
164+
"action": "close",
165+
"comment": "Thanks for creating this issue. We think this issue is unactionable or unrelated to the goals of this project. Please follow our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
166+
}
167+
]

‎.github/commands.yml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
# {
2+
# perform: true,
3+
# commands: [
4+
# {
5+
# type: 'comment',
6+
# name: 'findDuplicates',
7+
# allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
8+
# action: 'comment',
9+
# comment: "Potential duplicates:\n${potentialDuplicates}"
10+
# }
11+
# ]
12+
# }
13+
114
{
215
perform: true,
316
commands: [

‎.github/copycat.yml‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎.github/workflows/commands.yml‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: Commands
2+
on:
3+
issue_comment:
4+
types: [created]
5+
issues:
6+
types: [labeled]
7+
8+
jobs:
9+
main:
10+
runs-on: ubuntu-latest
11+
steps:
12+
- name: Checkout Actions
13+
uses: actions/checkout@v2
14+
with:
15+
repository: 'JacksonKearl/vscode-triage-github-actions'
16+
ref: v2
17+
# - name: Run Commands
18+
# uses: ./commands
19+
# with:
20+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
21+
# config-path: commands

‎.github/workflows/copycat.yml‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
name: CopyCat
2+
on:
3+
issues:
4+
types: [opened]
5+
6+
jobs:
7+
main:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- name: Checkout Actions
11+
uses: actions/checkout@v2
12+
with:
13+
repository: 'JacksonKearl/vscode-triage-github-actions'
14+
ref: v2
15+
# - name: Run CopyCat (JacksonKearl/testissues)
16+
# uses: ./copycat
17+
# with:
18+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
19+
# owner: JacksonKearl
20+
# repo: testissues
21+
# - name: Run CopyCat (chrmarti/testissues)
22+
# uses: ./copycat
23+
# with:
24+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
25+
# owner: chrmarti
26+
# repo: testissues

‎.github/workflows/needs-version-info.yml‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: Needs Version Info
2+
on:
3+
issues:
4+
types: [opened]
5+
6+
jobs:
7+
main:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- name: Checkout Actions
11+
uses: actions/checkout@v2
12+
with:
13+
repository: 'JacksonKearl/vscode-triage-github-actions'
14+
ref: v2
15+
# - name: Run Needs Version Info
16+
# uses: ./needs-more-info
17+
# with:
18+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
19+
# matcher: '\b(\d\.\d{2,3}\.\d|insiders?|1\.\d\d\d?)\b'
20+
# label: ~needs version info

‎build/builtInExtensions.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
},
4747
{
4848
"name": "ms-vscode.js-debug-nightly",
49-
"version": "2020.3.317",
49+
"version": "2020.3.1117",
5050
"forQualities": [
5151
"insider"
5252
],

‎build/lib/i18n.js‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ let XLF = /** @class */ (() => {
114114
for (let file in this.files) {
115115
this.appendNewLine(`<file original="${file}" source-language="en" datatype="plaintext"><body>`, 2);
116116
for (let item of this.files[file]) {
117-
this.addStringItem(item);
117+
this.addStringItem(file, item);
118118
}
119119
this.appendNewLine('</body></file>', 2);
120120
}
@@ -154,9 +154,12 @@ let XLF = /** @class */ (() => {
154154
this.files[original].push({ id: realKey, message: message, comment: comment });
155155
}
156156
}
157-
addStringItem(item) {
158-
if (!item.id || !item.message) {
159-
throw new Error(`No item ID or value specified: ${JSON.stringify(item)}`);
157+
addStringItem(file, item) {
158+
if (!item.id || item.message === undefined || item.message === null) {
159+
throw new Error(`No item ID or value specified: ${JSON.stringify(item)}. File: ${file}`);
160+
}
161+
if (item.message.length === 0) {
162+
log(`Item with id ${item.id} in file ${file} has an empty message.`);
160163
}
161164
this.appendNewLine(`<trans-unit id="${item.id}">`, 4);
162165
this.appendNewLine(`<source xml:lang="en">${item.message}</source>`, 6);

‎build/lib/i18n.ts‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ export class XLF {
201201
for (let file in this.files) {
202202
this.appendNewLine(`<file original="${file}" source-language="en" datatype="plaintext"><body>`, 2);
203203
for (let item of this.files[file]) {
204-
this.addStringItem(item);
204+
this.addStringItem(file, item);
205205
}
206206
this.appendNewLine('</body></file>', 2);
207207
}
@@ -243,9 +243,12 @@ export class XLF {
243243
}
244244
}
245245

246-
private addStringItem(item: Item): void {
247-
if (!item.id || !item.message) {
248-
throw new Error(`No item ID or value specified: ${JSON.stringify(item)}`);
246+
private addStringItem(file: string, item: Item): void {
247+
if (!item.id || item.message === undefined || item.message === null) {
248+
throw new Error(`No item ID or value specified: ${JSON.stringify(item)}. File: ${file}`);
249+
}
250+
if (item.message.length === 0) {
251+
log(`Item with id ${item.id} in file ${file} has an empty message.`);
249252
}
250253

251254
this.appendNewLine(`<trans-unit id="${item.id}">`, 4);

0 commit comments

Comments
 (0)