grid branch nodes should not forward children's preferred sizes

joaomoreno · joaomoreno · commit be402f0320f3 · 2019-01-30T09:41:58.000+01:00
diff --git a/src/vs/base/browser/ui/grid/gridview.ts b/src/vs/base/browser/ui/grid/gridview.ts
@@ -300,7 +300,7 @@ class BranchNode implements ISplitView, IDisposable {
 	}
 
 	private onDidChildrenChange(): void {
-		const onDidChildrenChange = Event.any(...this.children.map(c => c.onDidChange));
+		const onDidChildrenChange = Event.map(Event.any(...this.children.map(c => c.onDidChange)), () => undefined);
 		this.childrenChangeDisposable.dispose();
 		this.childrenChangeDisposable = onDidChildrenChange(this._onDidChange.fire, this._onDidChange);
 

Original file line number	Diff line number	Diff line change
`@@ -300,7 +300,7 @@ class BranchNode implements ISplitView, IDisposable {`
`300`	`300`	`}`
`301`	`301`
`302`	`302`	`private onDidChildrenChange(): void {`
`303`		`- const onDidChildrenChange = Event.any(...this.children.map(c => c.onDidChange));`
	`303`	`+ const onDidChildrenChange = Event.map(Event.any(...this.children.map(c => c.onDidChange)), () => undefined);`
`304`	`304`	`this.childrenChangeDisposable.dispose();`
`305`	`305`	`this.childrenChangeDisposable = onDidChildrenChange(this._onDidChange.fire, this._onDidChange);`
`306`	`306`