notifications - make microsoft#50931 a bit better

Benjamin Pasero · Benjamin Pasero · commit a668b4fee845 · 2019-04-04T15:14:53.000+02:00
diff --git a/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts b/src/vs/workbench/browser/parts/notifications/notificationsToasts.ts
@@ -191,6 +191,10 @@ export class NotificationsToasts extends Themable {
 
 		// Update when item height potentially changes due to label changes
 		itemDisposeables.push(item.onDidLabelChange(e => {
+			if (!item.expanded) {
+				return; // dynamic height only applies to expanded notifications
+			}
+
 			if (e.kind === NotificationViewItemLabelKind.ACTIONS || e.kind === NotificationViewItemLabelKind.MESSAGE) {
 				notificationList.updateNotificationsList(0, 1, [item]);
 			}
diff --git a/src/vs/workbench/browser/parts/notifications/notificationsViewer.ts b/src/vs/workbench/browser/parts/notifications/notificationsViewer.ts
@@ -350,6 +350,9 @@ export class NotificationTemplateRenderer {
 				case NotificationViewItemLabelKind.PROGRESS:
 					this.renderProgress(notification);
 					break;
+				case NotificationViewItemLabelKind.MESSAGE:
+					this.renderMessage(notification);
+					break;
 			}
 		}));
 	}

Original file line number	Diff line number	Diff line change
`@@ -350,6 +350,9 @@ export class NotificationTemplateRenderer {`
`350`	`350`	`case NotificationViewItemLabelKind.PROGRESS:`
`351`	`351`	`this.renderProgress(notification);`
`352`	`352`	`break;`
	`353`	`+ case NotificationViewItemLabelKind.MESSAGE:`
	`354`	`+ this.renderMessage(notification);`
	`355`	`+ break;`
`353`	`356`	`}`
`354`	`357`	`}));`
`355`	`358`	`}`