Have fallback message when code aciton command fails for unknown reason

mjbvz · mjbvz · commit 7d4a25395f0b · 2019-09-10T08:58:34.000-07:00
diff --git a/src/vs/editor/contrib/codeAction/codeActionCommands.ts b/src/vs/editor/contrib/codeAction/codeActionCommands.ts
@@ -130,9 +130,11 @@ export async function applyCodeAction(
 			await commandService.executeCommand(action.command.id, ...(action.command.arguments || []));
 		} catch (err) {
 			const message = asMessage(err);
-			if (typeof message === 'string') {
-				notificationService.error(message);
-			}
+			notificationService.error(
+				typeof message === 'string'
+					? message
+					: nls.localize('applyCodeActionFailed', "An unknown error occurred while applying the code action"));
+
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -130,9 +130,11 @@ export async function applyCodeAction(`
`130`	`130`	`await commandService.executeCommand(action.command.id, ...(action.command.arguments \|\| []));`
`131`	`131`	`} catch (err) {`
`132`	`132`	`const message = asMessage(err);`
`133`		`- if (typeof message === 'string') {`
`134`		`- notificationService.error(message);`
`135`		`- }`
	`133`	`+ notificationService.error(`
	`134`	`+ typeof message === 'string'`
	`135`	`+ ? message`
	`136`	`+ : nls.localize('applyCodeActionFailed', "An unknown error occurred while applying the code action"));`
	`137`	`+`
`136`	`138`	`}`
`137`	`139`	`}`
`138`	`140`	`}`