debugHover: fix scroll for complex hover

isidorn · isidorn · commit 5f443db84557 · 2017-06-28T14:51:11.000+02:00
fixes microsoft#29484
diff --git a/src/vs/workbench/parts/debug/browser/media/debugHover.css b/src/vs/workbench/parts/debug/browser/media/debugHover.css
@@ -26,7 +26,7 @@
 	word-break: normal;
 	text-overflow: ellipsis;
 	height: 18px;
-	overflow: auto;
+	overflow: hidden;
 	border-bottom: 1px solid rgba(128, 128, 128, 0.35);
 }
 
diff --git a/src/vs/workbench/parts/debug/electron-browser/debugHover.ts b/src/vs/workbench/parts/debug/electron-browser/debugHover.ts
@@ -7,6 +7,7 @@ import * as nls from 'vs/nls';
 import * as lifecycle from 'vs/base/common/lifecycle';
 import { TPromise } from 'vs/base/common/winjs.base';
 import { KeyCode } from 'vs/base/common/keyCodes';
+import { ScrollbarVisibility } from 'vs/base/common/scrollable';
 import * as dom from 'vs/base/browser/dom';
 import { ITree } from 'vs/base/parts/tree/browser/tree';
 import { Tree } from 'vs/base/parts/tree/browser/treeImpl';
@@ -62,7 +63,7 @@ export class DebugHoverWidget implements IContentWidget {
 		this.valueContainer = $('.value');
 		this.valueContainer.tabIndex = 0;
 		this.valueContainer.setAttribute('role', 'tooltip');
-		this.scrollbar = new DomScrollableElement(this.valueContainer, {});
+		this.scrollbar = new DomScrollableElement(this.valueContainer, { horizontal: ScrollbarVisibility.Hidden });
 		this.domNode.appendChild(this.scrollbar.getDomNode());
 		this.toDispose.push(this.scrollbar);
 
@@ -268,6 +269,7 @@ export class DebugHoverWidget implements IContentWidget {
 
 		this.valueContainer.hidden = true;
 		this.complexValueContainer.hidden = false;
+		this.scrollbar.scanDomNode();
 
 		return this.tree.setInput(expression).then(() => {
 			this.complexValueTitle.textContent = expression.value;

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`word-break: normal;`
`27`	`27`	`text-overflow: ellipsis;`
`28`	`28`	`height: 18px;`
`29`		`- overflow: auto;`
	`29`	`+ overflow: hidden;`
`30`	`30`	`border-bottom: 1px solid rgba(128, 128, 128, 0.35);`
`31`	`31`	`}`
`32`	`32`