Enclose global gulp path with quotes microsoft#68413 (microsoft#68418)

apupier · alexr00 · commit 1acabe663a4e · 2019-02-13T09:41:17.000+01:00
it will allow to have it working when path contains space Fixes microsoft#68413
diff --git a/extensions/gulp/src/main.ts b/extensions/gulp/src/main.ts
@@ -122,7 +122,7 @@ class FolderDetector {
 		if (platform === 'win32' && await exists(path.join(rootPath!, 'node_modules', '.bin', 'gulp.cmd'))) {
 			const globalGulp = path.join(process.env.APPDATA ? process.env.APPDATA : '', 'npm', 'gulp.cmd');
 			if (await exists(globalGulp)) {
-				gulpCommand = globalGulp;
+				gulpCommand = '"' + globalGulp + '"';
 			} else {
 				gulpCommand = path.join('.', 'node_modules', '.bin', 'gulp.cmd');
 			}

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ class FolderDetector {`
`122`	`122`	`if (platform === 'win32' && await exists(path.join(rootPath!, 'node_modules', '.bin', 'gulp.cmd'))) {`
`123`	`123`	`const globalGulp = path.join(process.env.APPDATA ? process.env.APPDATA : '', 'npm', 'gulp.cmd');`
`124`	`124`	`if (await exists(globalGulp)) {`
`125`		`- gulpCommand = globalGulp;`
	`125`	`+ gulpCommand = '"' + globalGulp + '"';`
`126`	`126`	`} else {`
`127`	`127`	`gulpCommand = path.join('.', 'node_modules', '.bin', 'gulp.cmd');`
`128`	`128`	`}`