Marking some more editor interface fields readonly

Matt Bierner · Matt Bierner · commit 09ac3c5dd623 · 2018-12-17T14:56:28.000-08:00
diff --git a/src/vs/editor/common/services/resolverService.ts b/src/vs/editor/common/services/resolverService.ts
@@ -39,7 +39,7 @@ export interface ITextEditorModel extends IEditorModel {
 	/**
 	 * Provides access to the underlying `ITextModel`.
 	 */
-	textEditorModel: ITextModel;
+	readonly textEditorModel: ITextModel;
 
 	isReadonly(): boolean;
 }
diff --git a/src/vs/platform/editor/common/editor.ts b/src/vs/platform/editor/common/editor.ts
@@ -11,7 +11,7 @@ export interface IEditorModel {
 	/**
 	 * Emitted when the model is disposed.
 	 */
-	onDispose: Event<void>;
+	readonly onDispose: Event<void>;
 
 	/**
 	 * Loads the model.
@@ -34,12 +34,12 @@ export interface IBaseResourceInput {
 	/**
 	 * Label to show for the diff editor
 	 */
-	label?: string;
+	readonly label?: string;
 
 	/**
 	 * Description to show for the diff editor
 	 */
-	description?: string;
+	readonly description?: string;
 
 	/**
 	 * Hint to indicate that this input should be treated as a file
@@ -48,7 +48,7 @@ export interface IBaseResourceInput {
 	 * Without this hint, the editor service will make a guess by
 	 * looking at the scheme of the resource(s).
 	 */
-	forceFile?: boolean;
+	readonly forceFile?: boolean;
 }
 
 export interface IResourceInput extends IBaseResourceInput {
@@ -61,7 +61,7 @@ export interface IResourceInput extends IBaseResourceInput {
 	/**
 	 * The encoding of the text input if known.
 	 */
-	encoding?: string;
+	readonly encoding?: string;
 }
 
 export interface IEditorOptions {
@@ -112,10 +112,10 @@ export interface IEditorOptions {
 }
 
 export interface ITextEditorSelection {
-	startLineNumber: number;
-	startColumn: number;
-	endLineNumber?: number;
-	endColumn?: number;
+	readonly startLineNumber: number;
+	readonly startColumn: number;
+	readonly endLineNumber?: number;
+	readonly endColumn?: number;
 }
 
 export interface ITextEditorOptions extends IEditorOptions {

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ export interface ITextEditorModel extends IEditorModel {`
`39`	`39`	`/**`
`40`	`40`	* Provides access to the underlying `ITextModel`.
`41`	`41`	`*/`
`42`		`- textEditorModel: ITextModel;`
	`42`	`+ readonly textEditorModel: ITextModel;`
`43`	`43`
`44`	`44`	`isReadonly(): boolean;`
`45`	`45`	`}`