Make sure process.kill is always called with a numeric PID.

Ben Newman · Ben Newman · commit a56c37db1a3a · 2016-05-10T16:56:42.000-04:00
This appears to be one of the biggest changes between Node v0.10 and v4.4 for the Meteor codebase. Relevant commit: nodejs/node@832ec1c Part of meteor#6921.
diff --git a/tools/inspector.js b/tools/inspector.js
@@ -227,7 +227,9 @@ DEp.stop = function stop() {
   var proc = this.inspectorProcess;
   if (proc && proc.kill) {
     this.inspectorProcess = null;
-    proc.kill();
+    // The .kill method now requires a numeric argument:
+    // https://github.com/nodejs/node/commit/832ec1cd50
+    proc.kill(proc.pid);
   }
 
   if (this.interceptServer) {
diff --git a/tools/runners/run-app.js b/tools/runners/run-app.js
@@ -166,7 +166,9 @@ _.extend(AppProcess.prototype, {
     if (self.proc && self.proc.pid) {
       self.proc.removeAllListeners('close');
       self.proc.removeAllListeners('error');
-      self.proc.kill();
+      // The .kill method now requires a numeric argument:
+      // https://github.com/nodejs/node/commit/832ec1cd50
+      self.proc.kill(self.proc.pid);
     }
     self.proc = null;
 
diff --git a/tools/runners/run-mongo.js b/tools/runners/run-mongo.js
@@ -475,7 +475,9 @@ var launchMongo = function (options) {
       stop: function () {
         if (proc) {
           proc.removeListener('exit', procExitHandler);
-          proc.kill('SIGINT');
+          // The .kill method now requires a numeric first argument:
+          // https://github.com/nodejs/node/commit/832ec1cd50
+          proc.kill(proc.pid, 'SIGINT');
           proc = null;
         }
       }
diff --git a/tools/runners/run-velocity.js b/tools/runners/run-velocity.js
@@ -30,7 +30,9 @@ var runVelocity = function (url) {
 
   var killBrowserProcesses = function () {
     browserProcesses.forEach(function (browserProcess) {
-      browserProcess.kill('SIGINT');
+      // The .kill method now requires a numeric first argument:
+      // https://github.com/nodejs/node/commit/832ec1cd50
+      browserProcess.kill(browserProcess.pid, 'SIGINT');
     });
     browserProcesses = [];
   };
diff --git a/tools/tool-testing/selftest.js b/tools/tool-testing/selftest.js
@@ -966,7 +966,9 @@ _.extend(PhantomClient.prototype, {
     var self = this;
     // Suppress the expected SIGTERM exit 'failure'
     self._logError = false;
-    self.process && self.process.kill();
+    // The .kill method now requires a numeric first argument:
+    // https://github.com/nodejs/node/commit/832ec1cd50
+    self.process && self.process.kill(self.process.pid);
     self.process = null;
   }
 });
@@ -1031,7 +1033,10 @@ _.extend(BrowserStackClient.prototype, {
 
   stop: function() {
     var self = this;
-    self.tunnelProcess && self.tunnelProcess.kill();
+    // The .kill method now requires a numeric first argument:
+    // https://github.com/nodejs/node/commit/832ec1cd50
+    self.tunnelProcess &&
+      self.tunnelProcess.kill(self.tunnelProcess.pid);
     self.tunnelProcess = null;
 
     self.driver && self.driver.quit();
@@ -1406,7 +1411,9 @@ _.extend(Run.prototype, {
       // processes.
       utils.execFileSync("taskkill", ["/pid", this.proc.pid, '/f', '/t']);
     } else {
-      this.proc.kill();
+      // The .kill method now requires a numeric first argument:
+      // https://github.com/nodejs/node/commit/832ec1cd50
+      this.proc.kill(this.proc.pid);
     }
   },
 

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,9 @@ var launchMongo = function (options) {`
`475`	`475`	`stop: function () {`
`476`	`476`	`if (proc) {`
`477`	`477`	`proc.removeListener('exit', procExitHandler);`
`478`		`- proc.kill('SIGINT');`
	`478`	`+ // The .kill method now requires a numeric first argument:`
	`479`	`+ // https://github.com/nodejs/node/commit/832ec1cd50`
	`480`	`+ proc.kill(proc.pid, 'SIGINT');`
`479`	`481`	`proc = null;`
`480`	`482`	`}`
`481`	`483`	`}`