Skip to content

Commit e3cf1ab

Browse files
authored
chore: add Trop annotations to release notes. (electron#24666)
1 parent 04e3a95 commit e3cf1ab

28 files changed

Lines changed: 527 additions & 234 deletions

script/release/notes/index.js

100755100644
Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ const getPreviousPoint = async (point) => {
120120
}
121121
};
122122

123-
async function getReleaseNotes (range, newVersion, explicitLinks) {
123+
async function getReleaseNotes (range, newVersion) {
124124
const rangeList = range.split('..') || ['HEAD'];
125125
const to = rangeList.pop();
126126
const from = rangeList.pop() || (await getPreviousPoint(to));
@@ -129,10 +129,9 @@ async function getReleaseNotes (range, newVersion, explicitLinks) {
129129
newVersion = to;
130130
}
131131

132-
console.log(`Generating release notes between ${from} and ${to} for version ${newVersion}`);
133132
const notes = await notesGenerator.get(from, to, newVersion);
134133
const ret = {
135-
text: notesGenerator.render(notes, explicitLinks)
134+
text: notesGenerator.render(notes)
136135
};
137136

138137
if (notes.unknown.length) {
@@ -144,7 +143,7 @@ async function getReleaseNotes (range, newVersion, explicitLinks) {
144143

145144
async function main () {
146145
const opts = minimist(process.argv.slice(2), {
147-
boolean: ['explicit-links', 'help'],
146+
boolean: ['help'],
148147
string: ['version']
149148
});
150149
opts.range = opts._.shift();
@@ -153,14 +152,13 @@ async function main () {
153152
console.log(`
154153
easy usage: ${name} version
155154
156-
full usage: ${name} [begin..]end [--version version] [--explicit-links]
155+
full usage: ${name} [begin..]end [--version version]
157156
158157
* 'begin' and 'end' are two git references -- tags, branches, etc --
159158
from which the release notes are generated.
160159
* if omitted, 'begin' defaults to the previous tag in end's branch.
161160
* if omitted, 'version' defaults to 'end'. Specifying a version is
162161
useful if you're making notes on a new version that isn't tagged yet.
163-
* 'explicit-links' makes every note's issue, commit, or pull an MD link
164162
165163
For example, these invocations are equivalent:
166164
${process.argv[1]} v4.0.1
@@ -169,7 +167,7 @@ For example, these invocations are equivalent:
169167
return 0;
170168
}
171169

172-
const notes = await getReleaseNotes(opts.range, opts.version, opts['explicit-links']);
170+
const notes = await getReleaseNotes(opts.range, opts.version);
173171
console.log(notes.text);
174172
if (notes.warning) {
175173
throw new Error(notes.warning);

0 commit comments

Comments
 (0)