fix: MakeAbsoluteFilePath is a blocking call (electron#23840)

zcbenz · web-flow · commit aa8d81511f3e · 2020-05-30T10:01:55.000-07:00
diff --git a/shell/common/api/electron_api_native_image.cc b/shell/common/api/electron_api_native_image.cc
@@ -62,6 +62,7 @@ base::FilePath NormalizePath(const base::FilePath& path) {
     return path;
   }
 
+  base::ThreadRestrictions::ScopedAllowIO allow_blocking;
   base::FilePath absolute_path = MakeAbsoluteFilePath(path);
   // MakeAbsoluteFilePath returns an empty path on failures so use original path
   if (absolute_path.empty()) {

Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ base::FilePath NormalizePath(const base::FilePath& path) {`
`62`	`62`	`return path;`
`63`	`63`	`}`
`64`	`64`
	`65`	`+ base::ThreadRestrictions::ScopedAllowIO allow_blocking;`
`65`	`66`	`base::FilePath absolute_path = MakeAbsoluteFilePath(path);`
`66`	`67`	`// MakeAbsoluteFilePath returns an empty path on failures so use original path`
`67`	`68`	`if (absolute_path.empty()) {`