fix: exclude crashpad_handler binary on linux (electron#23538)

nornagon · web-flow · commit 628248724546 · 2020-05-13T15:28:12.000-07:00
diff --git a/build/zip.py b/build/zip.py
@@ -25,6 +25,13 @@
   # //chrome/browser/resources/ssl/ssl_error_assistant, but we don't need to
   # ship it.
   'pyproto',
+
+  # On Windows, this binary doesn't exist (the crashpad handler is built-in).
+  # On MacOS, the binary is called 'chrome_crashpad_handler' and is inside the
+  # app bundle.
+  # On Linux, we don't use crashpad, but this binary is still built for some
+  # reason. Exclude it from the zip.
+  './crashpad_handler',
 ]
 
 def skip_path(dep, dist_zip, target_cpu):
diff --git a/script/lib/config.py b/script/lib/config.py
@@ -29,7 +29,6 @@
 LINUX_BINARIES = [
   'electron',
   'chrome-sandbox',
-  'crashpad_handler',
   'libffmpeg.so',
   'libGLESv2.so',
   'libEGL.so',
diff --git a/script/zip_manifests/dist_zip.linux.arm.manifest b/script/zip_manifests/dist_zip.linux.arm.manifest
@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version
diff --git a/script/zip_manifests/dist_zip.linux.arm64.manifest b/script/zip_manifests/dist_zip.linux.arm64.manifest
@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version
diff --git a/script/zip_manifests/dist_zip.linux.x64.manifest b/script/zip_manifests/dist_zip.linux.x64.manifest
@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version
diff --git a/script/zip_manifests/dist_zip.linux.x86.manifest b/script/zip_manifests/dist_zip.linux.x86.manifest
@@ -69,6 +69,5 @@ snapshot_blob.bin
 swiftshader/libEGL.so
 swiftshader/libGLESv2.so
 vk_swiftshader_icd.json
-crashpad_handler
 v8_context_snapshot.bin
 version
