chore: change some for loops to range-based (electron#26182)

dsanders11 · web-flow · commit 422190e1ff0a · 2020-10-27T10:22:24.000-07:00
diff --git a/chromium_src/chrome/browser/process_singleton_posix.cc b/chromium_src/chrome/browser/process_singleton_posix.cc
@@ -826,10 +826,9 @@ ProcessSingleton::NotifyResult ProcessSingleton::NotifyOtherProcessWithTimeout(
   to_send.append(current_dir.value());
 
   const std::vector<std::string>& argv = electron::ElectronCommandLine::argv();
-  for (std::vector<std::string>::const_iterator it = argv.begin();
-       it != argv.end(); ++it) {
+  for (const auto& arg : argv) {
     to_send.push_back(kTokenDelimiter);
-    to_send.append(*it);
+    to_send.append(arg);
   }
 
   // Send the message
diff --git a/chromium_src/chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc b/chromium_src/chrome/browser/ui/views/frame/global_menu_bar_registrar_x11.cc
@@ -122,8 +122,7 @@ void GlobalMenuBarRegistrarX11::OnNameOwnerChanged(GObject* /* ignored */,
                                                    GParamSpec* /* ignored */) {
   // If the name owner changed, we need to reregister all the live x11::Window
   // with the system.
-  for (std::set<x11::Window>::const_iterator it = live_windows_.begin();
-       it != live_windows_.end(); ++it) {
-    RegisterXWindow(*it);
+  for (const auto& window : live_windows_) {
+    RegisterXWindow(window);
   }
 }
diff --git a/shell/browser/api/electron_api_app.cc b/shell/browser/api/electron_api_app.cc
@@ -536,10 +536,10 @@ void OnClientCertificateSelected(
       data.c_str(), data.length(), net::X509Certificate::FORMAT_AUTO);
   if (!certs.empty()) {
     scoped_refptr<net::X509Certificate> cert(certs[0].get());
-    for (size_t i = 0; i < identities->size(); ++i) {
-      if (cert->EqualsExcludingChain((*identities)[i]->certificate())) {
+    for (auto& identity : *identities) {
+      if (cert->EqualsExcludingChain(identity->certificate())) {
         net::ClientCertIdentity::SelfOwningAcquirePrivateKey(
-            std::move((*identities)[i]),
+            std::move(identity),
             base::BindRepeating(&GotPrivateKey, delegate, std::move(cert)));
         break;
       }
diff --git a/shell/common/api/electron_api_v8_util.cc b/shell/common/api/electron_api_v8_util.cc
@@ -122,9 +122,9 @@ void ClearWeaklyTrackedValues() {
 
 std::vector<v8::Local<v8::Value>> GetWeaklyTrackedValues(v8::Isolate* isolate) {
   std::vector<v8::Local<v8::Value>> locals;
-  for (size_t i = 0; i < weakly_tracked_values.size(); i++) {
-    if (!weakly_tracked_values[i].IsEmpty())
-      locals.push_back(weakly_tracked_values[i].Get(isolate));
+  for (const auto& value : weakly_tracked_values) {
+    if (!value.IsEmpty())
+      locals.push_back(value.Get(isolate));
   }
   return locals;
 }
diff --git a/shell/common/api/electron_bindings.cc b/shell/common/api/electron_bindings.cc
@@ -109,10 +109,7 @@ void ElectronBindings::ActivateUVLoop(v8::Isolate* isolate) {
 // static
 void ElectronBindings::OnCallNextTick(uv_async_t* handle) {
   auto* self = static_cast<ElectronBindings*>(handle->data);
-  for (std::list<node::Environment*>::const_iterator it =
-           self->pending_next_ticks_.begin();
-       it != self->pending_next_ticks_.end(); ++it) {
-    node::Environment* env = *it;
+  for (auto* env : self->pending_next_ticks_) {
     gin_helper::Locker locker(env->isolate());
     v8::Context::Scope context_scope(env->context());
     v8::HandleScope handle_scope(env->isolate());

Original file line number	Diff line number	Diff line change
`@@ -122,8 +122,7 @@ void GlobalMenuBarRegistrarX11::OnNameOwnerChanged(GObject* /* ignored */,`
`122`	`122`	`GParamSpec* /* ignored */) {`
`123`	`123`	`// If the name owner changed, we need to reregister all the live x11::Window`
`124`	`124`	`// with the system.`
`125`		`- for (std::set<x11::Window>::const_iterator it = live_windows_.begin();`
`126`		`- it != live_windows_.end(); ++it) {`
`127`		`- RegisterXWindow(*it);`
	`125`	`+ for (const auto& window : live_windows_) {`
	`126`	`+ RegisterXWindow(window);`
`128`	`127`	`}`
`129`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -122,9 +122,9 @@ void ClearWeaklyTrackedValues() {`
`122`	`122`
`123`	`123`	`std::vector<v8::Local<v8::Value>> GetWeaklyTrackedValues(v8::Isolate* isolate) {`
`124`	`124`	`std::vector<v8::Local<v8::Value>> locals;`
`125`		`- for (size_t i = 0; i < weakly_tracked_values.size(); i++) {`
`126`		`- if (!weakly_tracked_values[i].IsEmpty())`
`127`		`- locals.push_back(weakly_tracked_values[i].Get(isolate));`
	`125`	`+ for (const auto& value : weakly_tracked_values) {`
	`126`	`+ if (!value.IsEmpty())`
	`127`	`+ locals.push_back(value.Get(isolate));`
`128`	`128`	`}`
`129`	`129`	`return locals;`
`130`	`130`	`}`