refactor(extensions): break load warnings into newlines (electron#25358)

samuelmaddock · web-flow · commit 1815b95e7495 · 2020-09-10T11:39:45.000+09:00
diff --git a/shell/browser/extensions/electron_extension_loader.cc b/shell/browser/extensions/electron_extension_loader.cc
@@ -52,9 +52,9 @@ std::pair<scoped_refptr<const Extension>, std::string> LoadUnpacked(
   // Log warnings.
   if (extension->install_warnings().size()) {
     warnings += "Warnings loading extension at " +
-                base::UTF16ToUTF8(extension_dir.LossyDisplayName()) + ": ";
+                base::UTF16ToUTF8(extension_dir.LossyDisplayName()) + ":\n";
     for (const auto& warning : extension->install_warnings()) {
-      warnings += warning.message + " ";
+      warnings += "  " + warning.message + "\n";
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,9 @@ std::pair<scoped_refptr<const Extension>, std::string> LoadUnpacked(`
`52`	`52`	`// Log warnings.`
`53`	`53`	`if (extension->install_warnings().size()) {`
`54`	`54`	`warnings += "Warnings loading extension at " +`
`55`		`- base::UTF16ToUTF8(extension_dir.LossyDisplayName()) + ": ";`
	`55`	`+ base::UTF16ToUTF8(extension_dir.LossyDisplayName()) + ":\n";`
`56`	`56`	`for (const auto& warning : extension->install_warnings()) {`
`57`		`- warnings += warning.message + " ";`
	`57`	`+ warnings += " " + warning.message + "\n";`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`