feat(api): add type to edit custom inspector state

Akryum · Akryum · commit a732553244f8 · 2021-06-07T17:46:30.000+02:00
diff --git a/packages/api/src/api/hooks.ts b/packages/api/src/api/hooks.ts
@@ -130,6 +130,7 @@ export type HookPayloads = {
     inspectorId: string
     nodeId: string
     path: string[]
+    type: string
     state: EditStatePayload
     set: (object: any, path: string | (string[]), value: any, cb?: (object: any, field: string, value: any) => void) => void
   }
diff --git a/packages/app-backend-api/src/api.ts b/packages/app-backend-api/src/api.ts
@@ -218,13 +218,14 @@ export class DevtoolsApi {
     return payload.state
   }
 
-  async editInspectorState (inspectorId: string, app: App, nodeId: string, dotPath: string, state: EditStatePayload) {
+  async editInspectorState (inspectorId: string, app: App, nodeId: string, dotPath: string, type: string, state: EditStatePayload) {
     const arrayPath = dotPath.split('.')
     await this.callHook(Hooks.EDIT_INSPECTOR_STATE, {
       inspectorId,
       app,
       nodeId,
       path: arrayPath,
+      type,
       state,
       set: (object, path = arrayPath, value = state.value, cb?) => set(object, path, value, cb || createDefaultSetCallback(state))
     })
diff --git a/packages/app-backend-core/src/index.ts b/packages/app-backend-core/src/index.ts
@@ -380,10 +380,10 @@ async function connect () {
     }
   })
 
-  ctx.bridge.on(BridgeEvents.TO_BACK_CUSTOM_INSPECTOR_EDIT_STATE, async ({ inspectorId, appId, nodeId, path, payload }) => {
+  ctx.bridge.on(BridgeEvents.TO_BACK_CUSTOM_INSPECTOR_EDIT_STATE, async ({ inspectorId, appId, nodeId, path, type, payload }) => {
     const inspector = getInspectorWithAppId(inspectorId, appId, ctx)
     if (inspector) {
-      await editInspectorState(inspector, nodeId, path, payload, ctx)
+      await editInspectorState(inspector, nodeId, path, type, payload, ctx)
       inspector.selectedNodeId = nodeId
       await sendInspectorState(inspector, ctx)
     } else {
diff --git a/packages/app-backend-core/src/inspector.ts b/packages/app-backend-core/src/inspector.ts
@@ -29,8 +29,8 @@ export async function sendInspectorState (inspector: CustomInspector, ctx: Backe
   })
 }
 
-export async function editInspectorState (inspector: CustomInspector, nodeId: string, dotPath: string, state: any, ctx: BackendContext) {
-  await ctx.api.editInspectorState(inspector.id, inspector.app, nodeId, dotPath, {
+export async function editInspectorState (inspector: CustomInspector, nodeId: string, dotPath: string, type: string, state: any, ctx: BackendContext) {
+  await ctx.api.editInspectorState(inspector.id, inspector.app, nodeId, dotPath, type, {
     ...state,
     value: state.value != null ? parse(state.value, true) : state.value
   })
diff --git a/packages/app-frontend/src/features/inspector/custom/composable.ts b/packages/app-frontend/src/features/inspector/custom/composable.ts
@@ -102,12 +102,13 @@ export function useCurrentInspector () {
     fetchState(currentInspector.value)
   }
 
-  function editState (path: string, payload: any) {
+  function editState (path: string, payload: any, type: string) {
     bridge.send(BridgeEvents.TO_BACK_CUSTOM_INSPECTOR_EDIT_STATE, {
       inspectorId: currentInspector.value.id,
       appId: currentInspector.value.appId,
       nodeId: currentInspector.value.selectedNodeId,
       path,
+      type,
       payload
     })
   }

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,7 @@ export type HookPayloads = {`
`130`	`130`	`inspectorId: string`
`131`	`131`	`nodeId: string`
`132`	`132`	`path: string[]`
	`133`	`+ type: string`
`133`	`134`	`state: EditStatePayload`
`134`	`135`	`set: (object: any, path: string \| (string[]), value: any, cb?: (object: any, field: string, value: any) => void) => void`
`135`	`136`	`}`
Original file line number	Diff line number	Diff line change
`@@ -102,12 +102,13 @@ export function useCurrentInspector () {`
`102`	`102`	`fetchState(currentInspector.value)`
`103`	`103`	`}`
`104`	`104`
`105`		`- function editState (path: string, payload: any) {`
	`105`	`+ function editState (path: string, payload: any, type: string) {`
`106`	`106`	`bridge.send(BridgeEvents.TO_BACK_CUSTOM_INSPECTOR_EDIT_STATE, {`
`107`	`107`	`inspectorId: currentInspector.value.id,`
`108`	`108`	`appId: currentInspector.value.appId,`
`109`	`109`	`nodeId: currentInspector.value.selectedNodeId,`
`110`	`110`	`path,`
	`111`	`+ type,`
`111`	`112`	`payload`
`112`	`113`	`})`
`113`	`114`	`}`