fix: some component updates skipped because of throttling

Akryum · Akryum · commit 13f650d8fa19 · 2022-03-14T14:43:34.000+01:00
diff --git a/packages/app-backend-core/src/index.ts b/packages/app-backend-core/src/index.ts
@@ -112,7 +112,25 @@ async function connect () {
 
   // Components
 
-  hook.on(HookEvents.COMPONENT_UPDATED, throttle(async (app, uid, parentUid, component) => {
+  const sendComponentUpdate = throttle(async (appRecord: AppRecord, id: string) => {
+    try {
+      // Update component inspector
+      if (id && isSubscribed(BridgeSubscriptions.SELECTED_COMPONENT_DATA, sub => sub.payload.instanceId === id)) {
+        await sendSelectedComponentData(appRecord, id, ctx)
+      }
+
+      // Update tree (tags)
+      if (isSubscribed(BridgeSubscriptions.COMPONENT_TREE, sub => sub.payload.instanceId === id)) {
+        await sendComponentTreeData(appRecord, id, appRecord.componentFilter, 0, ctx)
+      }
+    } catch (e) {
+      if (SharedData.debugInfo) {
+        console.error(e)
+      }
+    }
+  }, 100)
+
+  hook.on(HookEvents.COMPONENT_UPDATED, async (app, uid, parentUid, component) => {
     try {
       if (!app || !uid || !component) return
       let id: string
@@ -125,29 +143,21 @@ async function connect () {
         appRecord = ctx.currentAppRecord
       }
 
-      // Update component inspector
-      if (id && isSubscribed(BridgeSubscriptions.SELECTED_COMPONENT_DATA, sub => sub.payload.instanceId === id)) {
-        await sendSelectedComponentData(appRecord, id, ctx)
-      }
-
-      // Update tree (tags)
-      if (isSubscribed(BridgeSubscriptions.COMPONENT_TREE, sub => sub.payload.instanceId === id)) {
-        await sendComponentTreeData(appRecord, id, appRecord.componentFilter, 0, ctx)
-      }
-
       if (SharedData.trackUpdates) {
         await sendComponentUpdateTracking(id, ctx)
       }
 
       if (SharedData.flashUpdates) {
         await flashComponent(component, appRecord.backend)
       }
+
+      await sendComponentUpdate(appRecord, id)
     } catch (e) {
       if (SharedData.debugInfo) {
         console.error(e)
       }
     }
-  }, 1000 / 10))
+  })
 
   hook.on(HookEvents.COMPONENT_ADDED, async (app, uid, parentUid, component) => {
     try {
