Address CR feedback

ahejlsberg · ahejlsberg · commit ff6059abf69e · 2018-07-24T17:58:03.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -4372,7 +4372,7 @@ namespace ts {
                 case TypeSystemPropertyName.ImmediateBaseConstraint:
                     return !!(<Type>target).immediateBaseConstraint;
             }
-            return Debug.fail("Unhandled TypeSystemPropertyName " + propertyName);
+            return Debug.assertNever(propertyName);
         }
 
         // Pop an entry from the type resolution stack and return its associated result value. The result value will
@@ -7879,6 +7879,7 @@ namespace ts {
             return inferences && getIntersectionType(inferences);
         }
 
+        /** This is a worker function. Use getConstraintOfTypeParameter which guards against circular constraints. */
         function getConstraintFromTypeParameter(typeParameter: TypeParameter): Type | undefined {
             if (!typeParameter.constraint) {
                 if (typeParameter.target) {

Original file line number	Diff line number	Diff line change
`@@ -4372,7 +4372,7 @@ namespace ts {`
`4372`	`4372`	`case TypeSystemPropertyName.ImmediateBaseConstraint:`
`4373`	`4373`	`return !!(<Type>target).immediateBaseConstraint;`
`4374`	`4374`	`}`
`4375`		`- return Debug.fail("Unhandled TypeSystemPropertyName " + propertyName);`
	`4375`	`+ return Debug.assertNever(propertyName);`
`4376`	`4376`	`}`
`4377`	`4377`
`4378`	`4378`	`// Pop an entry from the type resolution stack and return its associated result value. The result value will`
`@@ -7879,6 +7879,7 @@ namespace ts {`
`7879`	`7879`	`return inferences && getIntersectionType(inferences);`
`7880`	`7880`	`}`
`7881`	`7881`
	`7882`	`+ /** This is a worker function. Use getConstraintOfTypeParameter which guards against circular constraints. */`
`7882`	`7883`	`function getConstraintFromTypeParameter(typeParameter: TypeParameter): Type \| undefined {`
`7883`	`7884`	`if (!typeParameter.constraint) {`
`7884`	`7885`	`if (typeParameter.target) {`