Fix for microsoft#5058 - Exclude implemented interface functions from autocompletion suggestions.

DanCorder · DanCorder · commit ff4147af01c1 · 2015-12-07T19:47:56.000Z
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -3751,7 +3751,8 @@ namespace ts {
                     // Ignore omitted expressions for missing members
                     if (m.kind !== SyntaxKind.PropertyAssignment &&
                         m.kind !== SyntaxKind.ShorthandPropertyAssignment &&
-                        m.kind !== SyntaxKind.BindingElement) {
+                        m.kind !== SyntaxKind.BindingElement &&
+                        m.kind !== SyntaxKind.MethodDeclaration) {
                         continue;
                     }
 
diff --git a/tests/cases/fourslash/completionListImplementingInterfaceFunctions.ts b/tests/cases/fourslash/completionListImplementingInterfaceFunctions.ts
@@ -0,0 +1,26 @@
+/// <reference path="fourslash.ts" />
+
+////interface I1 {
+////    a(): void;
+////    b(): void;
+////}
+////
+////var imp1: I1 {
+////    a() {},
+////    /*0*/
+////}
+////
+////interface I2 {
+////    a(): void;
+////    b(): void;
+////}
+////
+////var imp2: I2 {
+////    a: () => {},
+////    /*1*/
+////}
+
+goTo.marker("0");
+verify.not.completionListContains("a");
+goTo.marker("1");
+verify.not.completionListContains("a");

Original file line number	Diff line number	Diff line change
`@@ -3751,7 +3751,8 @@ namespace ts {`
`3751`	`3751`	`// Ignore omitted expressions for missing members`
`3752`	`3752`	`if (m.kind !== SyntaxKind.PropertyAssignment &&`
`3753`	`3753`	`m.kind !== SyntaxKind.ShorthandPropertyAssignment &&`
`3754`		`- m.kind !== SyntaxKind.BindingElement) {`
	`3754`	`+ m.kind !== SyntaxKind.BindingElement &&`
	`3755`	`+ m.kind !== SyntaxKind.MethodDeclaration) {`
`3755`	`3756`	`continue;`
`3756`	`3757`	`}`
`3757`	`3758`