Merge pull request microsoft#14343 from Microsoft/undefined_declarations

Andy · web-flow · commit fc9bcc1d8f8d · 2017-02-28T08:44:41.000-08:00
Add check for undefined declarations
diff --git a/src/services/goToDefinition.ts b/src/services/goToDefinition.ts
@@ -198,7 +198,11 @@ namespace ts.GoToDefinition {
             return false;
         }
 
-        function tryAddSignature(signatureDeclarations: Declaration[], selectConstructors: boolean, symbolKind: string, symbolName: string, containerName: string, result: DefinitionInfo[]) {
+        function tryAddSignature(signatureDeclarations: Declaration[] | undefined, selectConstructors: boolean, symbolKind: string, symbolName: string, containerName: string, result: DefinitionInfo[]) {
+            if (!signatureDeclarations) {
+                return false;
+            }
+
             const declarations: Declaration[] = [];
             let definition: Declaration | undefined;
 
diff --git a/tests/cases/fourslash/goToDefinition_untypedModule.ts b/tests/cases/fourslash/goToDefinition_untypedModule.ts
@@ -0,0 +1,10 @@
+/// <reference path='fourslash.ts' />
+
+// @Filename: /node_modules/foo/index.js
+////not read
+
+// @Filename: /a.ts
+////import { f } from "foo";
+/////**/f();
+
+verify.goToDefinition("", []);
