do not error if typings for external library is empty .d.ts file

vladima · vladima · commit fb99a6697d10 · 2016-02-02T11:36:38.000-08:00
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -1490,7 +1490,7 @@ namespace ts {
                         if (importedFile && resolution.isExternalLibraryImport) {
                             // Since currently irrespective of allowJs, we only look for supportedTypeScript extension external module files,
                             // this check is ok. Otherwise this would be never true for javascript file
-                            if (!isExternalModule(importedFile)) {
+                            if (!isExternalModule(importedFile) && importedFile.statements.length) {
                                 const start = getTokenPosOfNode(file.imports[i], file);
                                 fileProcessingDiagnostics.add(createFileDiagnostic(file, start, file.imports[i].end - start, Diagnostics.Exported_external_package_typings_file_0_is_not_a_module_Please_contact_the_package_author_to_update_the_package_definition, importedFile.fileName));
                             }
diff --git a/tests/baselines/reference/noErrorOnEmptyDts.js b/tests/baselines/reference/noErrorOnEmptyDts.js
@@ -0,0 +1,13 @@
+//// [tests/cases/compiler/noErrorOnEmptyDts.ts] ////
+
+//// [test.d.ts]
+
+
+// comment
+
+//// [main.ts]
+import "test"
+
+//// [main.js]
+"use strict";
+require("test");
diff --git a/tests/baselines/reference/noErrorOnEmptyDts.symbols b/tests/baselines/reference/noErrorOnEmptyDts.symbols
@@ -0,0 +1,8 @@
+=== c:/node_modules/test.d.ts ===
+
+No type information for this code.
+No type information for this code.// comment
+No type information for this code.
+No type information for this code.=== c:/app/main.ts ===
+import "test"
+No type information for this code.
diff --git a/tests/baselines/reference/noErrorOnEmptyDts.types b/tests/baselines/reference/noErrorOnEmptyDts.types
@@ -0,0 +1,8 @@
+=== c:/node_modules/test.d.ts ===
+
+No type information for this code.
+No type information for this code.// comment
+No type information for this code.
+No type information for this code.=== c:/app/main.ts ===
+import "test"
+No type information for this code.
diff --git a/tests/cases/compiler/noErrorOnEmptyDts.ts b/tests/cases/compiler/noErrorOnEmptyDts.ts
@@ -0,0 +1,8 @@
+// @module: commonjs
+
+// @filename: c:/node_modules/test.d.ts
+
+// comment
+
+// @filename: c:/app/main.ts
+import "test"

Original file line number	Diff line number	Diff line change
`@@ -1490,7 +1490,7 @@ namespace ts {`
`1490`	`1490`	`if (importedFile && resolution.isExternalLibraryImport) {`
`1491`	`1491`	`// Since currently irrespective of allowJs, we only look for supportedTypeScript extension external module files,`
`1492`	`1492`	`// this check is ok. Otherwise this would be never true for javascript file`
`1493`		`- if (!isExternalModule(importedFile)) {`
	`1493`	`+ if (!isExternalModule(importedFile) && importedFile.statements.length) {`
`1494`	`1494`	`const start = getTokenPosOfNode(file.imports[i], file);`
`1495`	`1495`	`fileProcessingDiagnostics.add(createFileDiagnostic(file, start, file.imports[i].end - start, Diagnostics.Exported_external_package_typings_file_0_is_not_a_module_Please_contact_the_package_author_to_update_the_package_definition, importedFile.fileName));`
`1496`	`1496`	`}`