no-restricted-globals

a-tarasyuk · a-tarasyuk · commit f96fb53e4c5a · 2019-06-14T10:12:06.000+03:00
diff --git a/.eslintrc b/.eslintrc
@@ -92,7 +92,13 @@
         "no-new-wrappers": "error",
         "no-redeclare": "off",
         "no-return-await": "error",
-        "no-restricted-globals": "off",
+        "no-restricted-globals": ["error",
+            { "name": "setTimeout" },
+            { "name": "setInterval" },
+            { "name": "clearTimeout" },
+            { "name": "setImmediate" },
+            { "name": "clearImmediate" }
+        ],
         "no-sequences": "off",
         "no-shadow": "off",
         "no-sparse-arrays": "error",
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -769,19 +769,22 @@ namespace Harness.LanguageService {
         }
 
         setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any {
-            // tslint:disable-next-line:ban
+            // eslint-disable-next-line no-restricted-globals
             return setTimeout(callback, ms, args);
         }
 
         clearTimeout(timeoutId: any): void {
+            // eslint-disable-next-line no-restricted-globals
             clearTimeout(timeoutId);
         }
 
         setImmediate(callback: (...args: any[]) => void, _ms: number, ...args: any[]): any {
+            // eslint-disable-next-line no-restricted-globals
             return setImmediate(callback, args);
         }
 
         clearImmediate(timeoutId: any): void {
+            // eslint-disable-next-line no-restricted-globals
             clearImmediate(timeoutId);
         }
 
diff --git a/src/testRunner/parallel/host.ts b/src/testRunner/parallel/host.ts
@@ -297,12 +297,15 @@ namespace Harness.Parallel.Host {
                             return process.exit(2);
                         }
                         case "timeout": {
-                            if (worker.timer) clearTimeout(worker.timer);
+                            if (worker.timer) {
+                                // eslint-disable-next-line no-restricted-globals
+                                clearTimeout(worker.timer);
+                            }
                             if (data.payload.duration === "reset") {
                                 worker.timer = undefined;
                             }
                             else {
-                                // tslint:disable-next-line:ban
+                                // eslint-disable-next-line no-restricted-globals
                                 worker.timer = setTimeout(killChild, data.payload.duration, data.payload);
                             }
                             break;
@@ -624,7 +627,7 @@ namespace Harness.Parallel.Host {
             shimNoopTestInterface(global);
         }
 
-        // tslint:disable-next-line:ban
+        // eslint-disable-next-line no-restricted-globals
         setTimeout(() => startDelayed(perfData, totalCost), 0); // Do real startup on next tick, so all unit tests have been collected
     }
 }
diff --git a/src/tsserver/server.ts b/src/tsserver/server.ts
@@ -482,6 +482,7 @@ namespace ts.server {
                     // so we defer until the next tick.
                     //
                     // Construction should finish before the next tick fires, so we do not need to do this recursively.
+                    // eslint-disable-next-line no-restricted-globals
                     setImmediate(() => this.event(body, eventName));
                 }
             };
@@ -698,7 +699,7 @@ namespace ts.server {
         // stat due to inconsistencies of fs.watch
         // and efficiency of stat on modern filesystems
         function startWatchTimer() {
-            // tslint:disable-next-line:ban
+            // eslint-disable-next-line no-restricted-globals
             setInterval(() => {
                 let count = 0;
                 let nextToCheck = nextFileToCheck;
@@ -881,10 +882,13 @@ namespace ts.server {
         };
     };
 
+    /* eslint-disable no-restricted-globals */
     sys.setTimeout = setTimeout;
     sys.clearTimeout = clearTimeout;
     sys.setImmediate = setImmediate;
     sys.clearImmediate = clearImmediate;
+    /* eslint-enable no-restricted-globals */
+
     if (typeof global !== "undefined" && global.gc) {
         sys.gc = () => global.gc();
     }

Original file line number	Diff line number	Diff line change
`@@ -769,19 +769,22 @@ namespace Harness.LanguageService {`
`769`	`769`	`}`
`770`	`770`
`771`	`771`	`setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any {`
`772`		`- // tslint:disable-next-line:ban`
	`772`	`+ // eslint-disable-next-line no-restricted-globals`
`773`	`773`	`return setTimeout(callback, ms, args);`
`774`	`774`	`}`
`775`	`775`
`776`	`776`	`clearTimeout(timeoutId: any): void {`
	`777`	`+ // eslint-disable-next-line no-restricted-globals`
`777`	`778`	`clearTimeout(timeoutId);`
`778`	`779`	`}`
`779`	`780`
`780`	`781`	`setImmediate(callback: (...args: any[]) => void, _ms: number, ...args: any[]): any {`
	`782`	`+ // eslint-disable-next-line no-restricted-globals`
`781`	`783`	`return setImmediate(callback, args);`
`782`	`784`	`}`
`783`	`785`
`784`	`786`	`clearImmediate(timeoutId: any): void {`
	`787`	`+ // eslint-disable-next-line no-restricted-globals`
`785`	`788`	`clearImmediate(timeoutId);`
`786`	`789`	`}`
`787`	`790`
Original file line number	Diff line number	Diff line change
`@@ -297,12 +297,15 @@ namespace Harness.Parallel.Host {`
`297`	`297`	`return process.exit(2);`
`298`	`298`	`}`
`299`	`299`	`case "timeout": {`
`300`		`- if (worker.timer) clearTimeout(worker.timer);`
	`300`	`+ if (worker.timer) {`
	`301`	`+ // eslint-disable-next-line no-restricted-globals`
	`302`	`+ clearTimeout(worker.timer);`
	`303`	`+ }`
`301`	`304`	`if (data.payload.duration === "reset") {`
`302`	`305`	`worker.timer = undefined;`
`303`	`306`	`}`
`304`	`307`	`else {`
`305`		`- // tslint:disable-next-line:ban`
	`308`	`+ // eslint-disable-next-line no-restricted-globals`
`306`	`309`	`worker.timer = setTimeout(killChild, data.payload.duration, data.payload);`
`307`	`310`	`}`
`308`	`311`	`break;`
`@@ -624,7 +627,7 @@ namespace Harness.Parallel.Host {`
`624`	`627`	`shimNoopTestInterface(global);`
`625`	`628`	`}`
`626`	`629`
`627`		`- // tslint:disable-next-line:ban`
	`630`	`+ // eslint-disable-next-line no-restricted-globals`
`628`	`631`	`setTimeout(() => startDelayed(perfData, totalCost), 0); // Do real startup on next tick, so all unit tests have been collected`
`629`	`632`	`}`
`630`	`633`	`}`