Optimize 'getSourceFile' to only get the source file once.

Andy Hanson · Andy Hanson · commit f6f7a78d8998 · 2016-09-07T09:29:38.000-07:00
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -127,7 +127,10 @@ namespace ts {
         }
 
         public getText(sourceFile?: SourceFile): string {
-            return (sourceFile || this.getSourceFile()).text.substring(this.getStart(), this.getEnd());
+            if (!sourceFile) {
+                sourceFile = this.getSourceFile();
+            }
+            return sourceFile.text.substring(this.getStart(sourceFile), this.getEnd());
         }
 
         private addSyntheticNodes(nodes: Node[], pos: number, end: number, useJSDocScanner?: boolean): number {
@@ -192,8 +195,8 @@ namespace ts {
                     }
                 }
                 // For syntactic classifications, all trivia are classcified together, including jsdoc comments.
-                // For that to work, the jsdoc comments should still be the leading trivia of the first child. 
-                // Restoring the scanner position ensures that. 
+                // For that to work, the jsdoc comments should still be the leading trivia of the first child.
+                // Restoring the scanner position ensures that.
                 pos = this.pos;
                 forEachChild(this, processNode, processNodes);
                 if (pos < this.end) {

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,10 @@ namespace ts {`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`public getText(sourceFile?: SourceFile): string {`
`130`		`- return (sourceFile \|\| this.getSourceFile()).text.substring(this.getStart(), this.getEnd());`
	`130`	`+ if (!sourceFile) {`
	`131`	`+ sourceFile = this.getSourceFile();`
	`132`	`+ }`
	`133`	`+ return sourceFile.text.substring(this.getStart(sourceFile), this.getEnd());`
`131`	`134`	`}`
`132`	`135`
`133`	`136`	`private addSyntheticNodes(nodes: Node[], pos: number, end: number, useJSDocScanner?: boolean): number {`
`@@ -192,8 +195,8 @@ namespace ts {`
`192`	`195`	`}`
`193`	`196`	`}`
`194`	`197`	`// For syntactic classifications, all trivia are classcified together, including jsdoc comments.`
`195`		`- // For that to work, the jsdoc comments should still be the leading trivia of the first child.`
`196`		`- // Restoring the scanner position ensures that.`
	`198`	`+ // For that to work, the jsdoc comments should still be the leading trivia of the first child.`
	`199`	`+ // Restoring the scanner position ensures that.`
`197`	`200`	`pos = this.pos;`
`198`	`201`	`forEachChild(this, processNode, processNodes);`
`199`	`202`	`if (pos < this.end) {`