Skip to content

Commit eda6eca

Browse files
RyanCavanaughRyanCavanaugh
committed
Merge remote-tracking branch 'upstream/master' into javaScriptModules
2 parents efa63b9 + 28c2887 commit eda6eca

95 files changed

Lines changed: 3332 additions & 1243 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎CONTRIBUTING.md‎

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,33 @@ e.g. to run all compiler baseline tests:
4747
jake runtests tests=compiler
4848
```
4949

50-
or to run specifc test: `tests\cases\compiler\2dArrays.ts`
50+
or to run a specific test: `tests\cases\compiler\2dArrays.ts`
5151

5252
```Shell
5353
jake runtests tests=2dArrays
5454
```
5555

56+
## Debugging the tests
57+
58+
To debug the tests, invoke the runtests-browser using jake.
59+
You will probably only want to debug one test at a time:
60+
61+
```Shell
62+
jake runtests-browser tests=2dArrays
63+
```
64+
65+
You can specify which browser to use for debugging. Currently Chrome and IE are supported:
66+
67+
```Shell
68+
jake runtests-browser tests=2dArrays browser=chrome
69+
```
70+
71+
You can debug with VS Code or Node instead with `jake runtests debug=true`:
72+
73+
```Shell
74+
jake runtests tests=2dArrays debug=true
75+
```
76+
5677
## Adding a Test
5778
To add a new testcase, simply place a `.ts` file in `tests\cases\compiler` containing code that exemplifies the bugfix or change you are making.
5879

‎lib/lib.core.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1225,7 +1225,7 @@ interface ArrayBuffer {
12251225
interface ArrayBufferConstructor {
12261226
prototype: ArrayBuffer;
12271227
new (byteLength: number): ArrayBuffer;
1228-
isView(arg: any): boolean;
1228+
isView(arg: any): arg is ArrayBufferView;
12291229
}
12301230
declare var ArrayBuffer: ArrayBufferConstructor;
12311231

‎lib/lib.core.es6.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1225,7 +1225,7 @@ interface ArrayBuffer {
12251225
interface ArrayBufferConstructor {
12261226
prototype: ArrayBuffer;
12271227
new (byteLength: number): ArrayBuffer;
1228-
isView(arg: any): boolean;
1228+
isView(arg: any): arg is ArrayBufferView;
12291229
}
12301230
declare var ArrayBuffer: ArrayBufferConstructor;
12311231

‎lib/lib.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1225,7 +1225,7 @@ interface ArrayBuffer {
12251225
interface ArrayBufferConstructor {
12261226
prototype: ArrayBuffer;
12271227
new (byteLength: number): ArrayBuffer;
1228-
isView(arg: any): boolean;
1228+
isView(arg: any): arg is ArrayBufferView;
12291229
}
12301230
declare var ArrayBuffer: ArrayBufferConstructor;
12311231

‎lib/lib.es6.d.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1225,7 +1225,7 @@ interface ArrayBuffer {
12251225
interface ArrayBufferConstructor {
12261226
prototype: ArrayBuffer;
12271227
new (byteLength: number): ArrayBuffer;
1228-
isView(arg: any): boolean;
1228+
isView(arg: any): arg is ArrayBufferView;
12291229
}
12301230
declare var ArrayBuffer: ArrayBufferConstructor;
12311231

0 commit comments

Comments
 (0)