Don't treat a declaration as a type argument position (microsoft#25046)

Andy · web-flow · commit e7b338e9432d · 2018-06-21T10:18:37.000-07:00
diff --git a/src/services/utilities.ts b/src/services/utilities.ts
@@ -948,7 +948,7 @@ namespace ts {
                     token = findPrecedingToken(token.getFullStart(), sourceFile);
                     if (!token || !isIdentifier(token)) return undefined;
                     if (!remainingLessThanTokens) {
-                        return { called: token, nTypeArguments };
+                        return isDeclarationName(token) ? undefined : { called: token, nTypeArguments };
                     }
                     remainingLessThanTokens--;
                     break;
diff --git a/tests/cases/fourslash/signatureHelpOnDeclaration.ts b/tests/cases/fourslash/signatureHelpOnDeclaration.ts
@@ -0,0 +1,6 @@
+/// <reference path='fourslash.ts' />
+
+////function f</**/
+////x
+
+verify.noSignatureHelp("");

Original file line number	Diff line number	Diff line change
`@@ -948,7 +948,7 @@ namespace ts {`
`948`	`948`	`token = findPrecedingToken(token.getFullStart(), sourceFile);`
`949`	`949`	`if (!token \|\| !isIdentifier(token)) return undefined;`
`950`	`950`	`if (!remainingLessThanTokens) {`
`951`		`- return { called: token, nTypeArguments };`
	`951`	`+ return isDeclarationName(token) ? undefined : { called: token, nTypeArguments };`
`952`	`952`	`}`
`953`	`953`	`remainingLessThanTokens--;`
`954`	`954`	`break;`