Handle msising tags for JsDoc nodes

Andy Hanson · Andy Hanson · commit e6610c5d54d7 · 2016-09-19T11:33:05.000-07:00
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -1604,7 +1604,7 @@ namespace ts {
 
     // @kind(SyntaxKind.JSDocComment)
     export interface JSDoc extends Node {
-        tags: NodeArray<JSDocTag>;
+        tags: NodeArray<JSDocTag> | undefined;
         comment: string | undefined;
     }
 
diff --git a/src/services/navigationBar.ts b/src/services/navigationBar.ts
@@ -218,15 +218,13 @@ namespace ts.NavigationBar {
                 break;
 
             default:
-                if (node.jsDocComments) {
-                    for (const jsDocComment of node.jsDocComments) {
-                        for (const tag of jsDocComment.tags) {
-                            if (tag.kind === SyntaxKind.JSDocTypedefTag) {
-                                addLeafNode(tag);
-                            }
+                forEach(node.jsDocComments, jsDocComment => {
+                    forEach(jsDocComment.tags, tag => {
+                        if (tag.kind === SyntaxKind.JSDocTypedefTag) {
+                            addLeafNode(tag);
                         }
-                    }
-                }
+                    });
+                });
 
                 forEachChild(node, addChildrenRecursively);
         }
diff --git a/tests/cases/fourslash/navigationBarJsDocCommentWithNoTags.ts b/tests/cases/fourslash/navigationBarJsDocCommentWithNoTags.ts
@@ -0,0 +1,18 @@
+/// <reference path="fourslash.ts"/>
+
+/////** Test */
+////export const Test = {}
+
+verify.navigationBar([
+    {
+        "text": "\"navigationBarJsDocCommentWithNoTags\"",
+        "kind": "module",
+        "childItems": [
+            {
+                "text": "Test",
+                "kind": "const",
+                "kindModifiers": "export"
+            }
+        ]
+    }
+]);

Original file line number	Diff line number	Diff line change
`@@ -1604,7 +1604,7 @@ namespace ts {`
`1604`	`1604`
`1605`	`1605`	`// @kind(SyntaxKind.JSDocComment)`
`1606`	`1606`	`export interface JSDoc extends Node {`
`1607`		`- tags: NodeArray<JSDocTag>;`
	`1607`	`+ tags: NodeArray<JSDocTag> \| undefined;`
`1608`	`1608`	`comment: string \| undefined;`
`1609`	`1609`	`}`
`1610`	`1610`