Add Log for When Typings Installer Finishes Updating the Types Registry

mjbvz · mjbvz · commit e44d419c9044 · 2017-05-04T20:04:46.000-07:00
**Bug** While investigating microsoft#15301, I was confused by the typing installer's log `Updating types-registry npm package...`. This was often the last line of the log file, leading me to believe that the types-registry update was still ongoing **Fix** Add an extra log for when the type-registry update completes successfully
diff --git a/src/server/typingsInstaller/nodeTypingsInstaller.ts b/src/server/typingsInstaller/nodeTypingsInstaller.ts
@@ -96,6 +96,9 @@ namespace ts.server.typingsInstaller {
                     this.log.writeLine(`Updating ${TypesRegistryPackageName} npm package...`);
                 }
                 this.execSync(`${this.npmPath} install ${TypesRegistryPackageName}`, { cwd: globalTypingsCacheLocation, stdio: "ignore" });
+                if (this.log.isEnabled()) {
+                    this.log.writeLine(`Updated ${TypesRegistryPackageName} npm package`);
+                }
             }
             catch (e) {
                 if (this.log.isEnabled()) {

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,9 @@ namespace ts.server.typingsInstaller {`
`96`	`96`	this.log.writeLine(`Updating ${TypesRegistryPackageName} npm package...`);
`97`	`97`	`}`
`98`	`98`	this.execSync(`${this.npmPath} install ${TypesRegistryPackageName}`, { cwd: globalTypingsCacheLocation, stdio: "ignore" });
	`99`	`+ if (this.log.isEnabled()) {`
	`100`	+ this.log.writeLine(`Updated ${TypesRegistryPackageName} npm package`);
	`101`	`+ }`
`99`	`102`	`}`
`100`	`103`	`catch (e) {`
`101`	`104`	`if (this.log.isEnabled()) {`