Add support for diff3-style conflict

katemihalikova · katemihalikova · commit e3e81b867303 · 2017-05-30T08:03:58.000+02:00
diff --git a/src/compiler/scanner.ts b/src/compiler/scanner.ts
@@ -429,6 +429,7 @@ namespace ts {
               case CharacterCodes.slash:
                   // starts of normal trivia
               case CharacterCodes.lessThan:
+              case CharacterCodes.bar:
               case CharacterCodes.equals:
               case CharacterCodes.greaterThan:
                   // Starts of conflict marker trivia
@@ -496,6 +497,7 @@ namespace ts {
                       break;
 
                   case CharacterCodes.lessThan:
+                  case CharacterCodes.bar:
                   case CharacterCodes.equals:
                   case CharacterCodes.greaterThan:
                       if (isConflictMarkerTrivia(text, pos)) {
@@ -562,12 +564,12 @@ namespace ts {
             }
         }
         else {
-            Debug.assert(ch === CharacterCodes.equals);
-            // Consume everything from the start of the mid-conflict marker to the start of the next
-            // end-conflict marker.
+            Debug.assert(ch === CharacterCodes.bar || ch === CharacterCodes.equals);
+            // Consume everything from the start of a ||||||| or ======= marker to the start
+            // of the next ======= or >>>>>>> marker.
             while (pos < len) {
-                const ch = text.charCodeAt(pos);
-                if (ch === CharacterCodes.greaterThan && isConflictMarkerTrivia(text, pos)) {
+                const currentChar = text.charCodeAt(pos);
+                if ((currentChar === CharacterCodes.equals || currentChar === CharacterCodes.greaterThan) && currentChar !== ch && isConflictMarkerTrivia(text, pos)) {
                     break;
                 }
 
@@ -1562,6 +1564,16 @@ namespace ts {
                         pos++;
                         return token = SyntaxKind.OpenBraceToken;
                     case CharacterCodes.bar:
+                        if (isConflictMarkerTrivia(text, pos)) {
+                            pos = scanConflictMarkerTrivia(text, pos, error);
+                            if (skipTrivia) {
+                                continue;
+                            }
+                            else {
+                                return token = SyntaxKind.ConflictMarkerTrivia;
+                            }
+                        }
+
                         if (text.charCodeAt(pos + 1) === CharacterCodes.bar) {
                             return pos += 2, token = SyntaxKind.BarBarToken;
                         }
diff --git a/src/services/classifier.ts b/src/services/classifier.ts
@@ -685,9 +685,9 @@ namespace ts {
                         continue;
                     }
 
-                    // for the ======== add a comment for the first line, and then lex all
-                    // subsequent lines up until the end of the conflict marker.
-                    Debug.assert(ch === CharacterCodes.equals);
+                    // for the ||||||| and ======== markers, add a comment for the first line,
+                    // and then lex all subsequent lines up until the end of the conflict marker.
+                    Debug.assert(ch === CharacterCodes.bar || ch === CharacterCodes.equals);
                     classifyDisabledMergeCode(text, start, end);
                 }
             }
@@ -782,8 +782,8 @@ namespace ts {
         }
 
         function classifyDisabledMergeCode(text: string, start: number, end: number) {
-            // Classify the line that the ======= marker is on as a comment.  Then just lex
-            // all further tokens and add them to the result.
+            // Classify the line that the ||||||| or ======= marker is on as a comment.
+            // Then just lex all further tokens and add them to the result.
             let i: number;
             for (i = start; i < end; i++) {
                 if (isLineBreak(text.charCodeAt(i))) {

Original file line number	Diff line number	Diff line change
`@@ -685,9 +685,9 @@ namespace ts {`
`685`	`685`	`continue;`
`686`	`686`	`}`
`687`	`687`
`688`		`- // for the ======== add a comment for the first line, and then lex all`
`689`		`- // subsequent lines up until the end of the conflict marker.`
`690`		`- Debug.assert(ch === CharacterCodes.equals);`
	`688`	`+ // for the \|\|\|\|\|\|\| and ======== markers, add a comment for the first line,`
	`689`	`+ // and then lex all subsequent lines up until the end of the conflict marker.`
	`690`	`+ Debug.assert(ch === CharacterCodes.bar \|\| ch === CharacterCodes.equals);`
`691`	`691`	`classifyDisabledMergeCode(text, start, end);`
`692`	`692`	`}`
`693`	`693`	`}`
`@@ -782,8 +782,8 @@ namespace ts {`
`782`	`782`	`}`
`783`	`783`
`784`	`784`	`function classifyDisabledMergeCode(text: string, start: number, end: number) {`
`785`		`- // Classify the line that the ======= marker is on as a comment. Then just lex`
`786`		`- // all further tokens and add them to the result.`
	`785`	`+ // Classify the line that the \|\|\|\|\|\|\| or ======= marker is on as a comment.`
	`786`	`+ // Then just lex all further tokens and add them to the result.`
`787`	`787`	`let i: number;`
`788`	`788`	`for (i = start; i < end; i++) {`
`789`	`789`	`if (isLineBreak(text.charCodeAt(i))) {`