PR fixups

RyanCavanaugh · RyanCavanaugh · commit e1e2882edf26 · 2018-06-15T10:48:46.000-07:00
diff --git a/Jakefile.js b/Jakefile.js
@@ -161,8 +161,7 @@ task(TaskNames.lkg, [
     exec(`${host} ${Paths.scripts.produceLKG}`, () => {
         const sizeAfter = getDirSize(Paths.lkg);
         if (sizeAfter > (sizeBefore * 1.10)) {
-            // throw new Error("The lib folder increased by 10% or more. This likely indicates a bug.");
-            console.log("Seems too big");
+            throw new Error("The lib folder increased by 10% or more. This likely indicates a bug.");
         }
     
         complete();
@@ -362,20 +361,6 @@ file(Paths.servicesDefinitionFile, [TaskNames.coreBuild], function() {
     }
 }, { async: true });
 
-/*
-file(Paths.tsserverLibraryDefinitionFile, [TaskNames.coreBuild, Paths.copyright, ...libraryTargets], function () {
-    const content = fs.readFileSync(Paths.tsserverLibraryDefinitionFile, { encoding: 'utf-8' });
-    const newContent =
-        removeConstModifierFromEnumDeclarations(content) +
-        `\nexport = ts` +
-        `\nexport as namespace ts;`;
-
-    fs.writeFileSync(Paths.tsserverLibraryDefinitionFile, newContent, { encoding: 'utf-8' });
-});
-*/
-
-
-
 function getLibraryTargets() {
     /** @type {{ libs: string[], paths?: Record<string, string>, sources?: Record<string, string[]> }} */
     const libraries = readJson("./src/lib/libs.json");
@@ -540,7 +525,6 @@ function cleanTestDirs() {
     }
 
     jake.mkdirP(Paths.baselines.local);
-    jake.mkdirP(Paths.baselines.localRwc);
     jake.mkdirP(Paths.baselines.localTest262);
 }
 
@@ -627,6 +611,7 @@ function acceptBaseline(sourceFolder, targetFolder) {
     console.log('Accept baselines from ' + sourceFolder + ' to ' + targetFolder);
     var deleteEnding = '.delete';
 
+    jake.mkdirP(targetFolder);
     acceptBaselineFolder(sourceFolder, targetFolder);
 
     function acceptBaselineFolder(sourceFolder, targetFolder) {
diff --git a/src/compiler/tsbuild.ts b/src/compiler/tsbuild.ts
@@ -1109,7 +1109,7 @@ namespace ts {
             return resolvedNames;
         }
 
-        function buildAllProjects(): number {
+        function buildAllProjects(): ExitStatus {
             const graph = getGlobalDependencyGraph();
             if (graph === undefined) return ExitStatus.DiagnosticsPresent_OutputsSkipped;
 

Original file line number	Diff line number	Diff line change
`@@ -1109,7 +1109,7 @@ namespace ts {`
`1109`	`1109`	`return resolvedNames;`
`1110`	`1110`	`}`
`1111`	`1111`
`1112`		`- function buildAllProjects(): number {`
	`1112`	`+ function buildAllProjects(): ExitStatus {`
`1113`	`1113`	`const graph = getGlobalDependencyGraph();`
`1114`	`1114`	`if (graph === undefined) return ExitStatus.DiagnosticsPresent_OutputsSkipped;`
`1115`	`1115`