Test non-identifier rest in destructuring assignment

sandersn · sandersn · commit de9f59a30190 · 2016-11-11T08:57:11.000-08:00
diff --git a/tests/baselines/reference/objectRestNegative.errors.txt b/tests/baselines/reference/objectRestNegative.errors.txt
@@ -1,9 +1,10 @@
 tests/cases/conformance/types/rest/objectRestNegative.ts(2,10): error TS2462: A rest element must be last in a destructuring pattern
 tests/cases/conformance/types/rest/objectRestNegative.ts(3,31): error TS2462: A rest element must be last in a destructuring pattern
 tests/cases/conformance/types/rest/objectRestNegative.ts(6,17): error TS2700: Rest types may only be created from object types.
+tests/cases/conformance/types/rest/objectRestNegative.ts(11,9): error TS2701: An object rest element must be an identifier.
 
 
-==== tests/cases/conformance/types/rest/objectRestNegative.ts (3 errors) ====
+==== tests/cases/conformance/types/rest/objectRestNegative.ts (4 errors) ====
     let o = { a: 1, b: 'no' };
     var { ...mustBeLast, a } = o;
              ~~~~~~~~~~
@@ -18,4 +19,9 @@ tests/cases/conformance/types/rest/objectRestNegative.ts(6,17): error TS2700: Re
 !!! error TS2700: Rest types may only be created from object types.
         return rest;
     }
+    
+    let rest: { b: string }
+    ({a, ...rest.b + rest.b} = o);
+            ~~~~~~~~~~~~~~~
+!!! error TS2701: An object rest element must be an identifier.
     
diff --git a/tests/baselines/reference/objectRestNegative.js b/tests/baselines/reference/objectRestNegative.js
@@ -7,6 +7,9 @@ function generic<T extends { x, y }>(t: T) {
     let { x, ...rest } = t;
     return rest;
 }
+
+let rest: { b: string }
+({a, ...rest.b + rest.b} = o);
 
 
 //// [objectRestNegative.js]
@@ -25,3 +28,5 @@ function generic(t) {
     var x = t.x, rest = __rest(t, ["x"]);
     return rest;
 }
+var rest;
+(a = o.a, o, o);
diff --git a/tests/cases/conformance/types/rest/objectRestNegative.ts b/tests/cases/conformance/types/rest/objectRestNegative.ts
@@ -6,3 +6,6 @@ function generic<T extends { x, y }>(t: T) {
     let { x, ...rest } = t;
     return rest;
 }
+
+let rest: { b: string }
+({a, ...rest.b + rest.b} = o);

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,9 @@ function generic<T extends { x, y }>(t: T) {`
`7`	`7`	`let { x, ...rest } = t;`
`8`	`8`	`return rest;`
`9`	`9`	`}`
	`10`	`+`
	`11`	`+let rest: { b: string }`
	`12`	`+({a, ...rest.b + rest.b} = o);`
`10`	`13`
`11`	`14`
`12`	`15`	`//// [objectRestNegative.js]`
`@@ -25,3 +28,5 @@ function generic(t) {`
`25`	`28`	`var x = t.x, rest = __rest(t, ["x"]);`
`26`	`29`	`return rest;`
`27`	`30`	`}`
	`31`	`+var rest;`
	`32`	`+(a = o.a, o, o);`
Original file line number	Diff line number	Diff line change
`@@ -6,3 +6,6 @@ function generic<T extends { x, y }>(t: T) {`
`6`	`6`	`let { x, ...rest } = t;`
`7`	`7`	`return rest;`
`8`	`8`	`}`
	`9`	`+`
	`10`	`+let rest: { b: string }`
	`11`	`+({a, ...rest.b + rest.b} = o);`