Don't rename static 'this' when renaming class (microsoft#22235)

Andy · web-flow · commit dd27288e5ab0 · 2018-03-02T10:23:08.000-08:00
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -1010,7 +1010,7 @@ namespace ts.FindAllReferences.Core {
 
     function addClassStaticThisReferences(referenceLocation: Node, search: Search, state: State): void {
         addReference(referenceLocation, search.symbol, state);
-        if (isClassLike(referenceLocation.parent)) {
+        if (!state.options.isForRename && isClassLike(referenceLocation.parent)) {
             Debug.assert(referenceLocation.parent.name === referenceLocation);
             // This is the class declaration.
             addStaticThisReferences(referenceLocation.parent, state.referenceAdder(search.symbol));
diff --git a/tests/cases/fourslash/findAllRefsClassWithStaticThisAccess.ts b/tests/cases/fourslash/findAllRefsClassWithStaticThisAccess.ts
@@ -9,4 +9,6 @@
 
 const [r0, r1, r2] = test.ranges();
 verify.referenceGroups(r0, [{ definition: "class C", ranges: [r0, r1, r2] }]);
-verify.referenceGroups([r1, r2], [{ definition: "this: typeof C", ranges: [r1, r2] }]);
+verify.singleReferenceGroup("this: typeof C", [r1, r2]);
+
+verify.renameLocations(r0, [r0]);
