Yes space after multiline comments

ubershmekel · ubershmekel · commit dcd2ddd0b71f · 2017-09-26T12:09:58.000-07:00
diff --git a/src/compiler/comments.ts b/src/compiler/comments.ts
@@ -274,6 +274,9 @@ namespace ts {
             if (hasTrailingNewLine) {
                 writer.writeLine();
             }
+            else if (_kind === SyntaxKind.MultiLineCommentTrivia) {
+                writer.write(" ");
+            }
         }
 
         function emitLeadingCommentsOfPosition(pos: number) {
diff --git a/tests/baselines/reference/baseIndexSignatureResolution.js b/tests/baselines/reference/baseIndexSignatureResolution.js
@@ -59,4 +59,4 @@ interface B<TBase extends Base> extends A {
 }
 var b: B<Derived> = null;
 var z: Derived = b.foo();
-*/
+*/ 
diff --git a/tests/baselines/reference/commentEmitWithCommentOnLastLine.js b/tests/baselines/reference/commentEmitWithCommentOnLastLine.js
@@ -8,4 +8,4 @@ var bar;
 var x;
 /*
 var bar;
-*/
+*/ 
diff --git a/tests/baselines/reference/commentOnArrayElement1.js b/tests/baselines/reference/commentOnArrayElement1.js
@@ -11,7 +11,7 @@ var array = [
 var array = [
     /* element 1*/
     1
-    /* end of element 1 */,
+    /* end of element 1 */ ,
     2
     /* end of element 2 */
 ];
diff --git a/tests/baselines/reference/commentOnArrayElement3.js b/tests/baselines/reference/commentOnArrayElement3.js
@@ -12,8 +12,8 @@ var array = [
 var array = [
     /* element 1*/
     1
-    /* end of element 1 */,
+    /* end of element 1 */ ,
     2
-    /* end of element 2 */,
+    /* end of element 2 */ ,
     ,
 ];
diff --git a/tests/baselines/reference/commentOnBlock1.js b/tests/baselines/reference/commentOnBlock1.js
@@ -7,5 +7,5 @@ function f() {
 //// [commentOnBlock1.js]
 // asdf
 function f() {
-    /*asdf*/{ }
+    /*asdf*/ { }
 }
diff --git a/tests/baselines/reference/commentsArgumentsOfCallExpression1.js b/tests/baselines/reference/commentsArgumentsOfCallExpression1.js
@@ -29,4 +29,4 @@ function () { });
 foo(/*c7*/ function () { });
 foo(
 /*c7*/
-/*c8*/function () { });
+/*c8*/ function () { });
diff --git a/tests/baselines/reference/commentsArgumentsOfCallExpression2.js b/tests/baselines/reference/commentsArgumentsOfCallExpression2.js
@@ -17,7 +17,7 @@ foo(/*c2*/ 1, /*d2*/ 1 + 2, /*e1*/ a + b);
 foo(/*c3*/ function () { }, /*d2*/ function () { }, /*e2*/ a + /*e3*/ b);
 foo(/*c3*/ function () { }, /*d3*/ function () { }, /*e3*/ (a + b));
 foo(
-/*c4*/function () { }, 
-/*d4*/function () { }, 
+/*c4*/ function () { }, 
+/*d4*/ function () { }, 
 /*e4*/
-/*e5*/"hello");
+/*e5*/ "hello");
diff --git a/tests/baselines/reference/commentsCommentParsing.js b/tests/baselines/reference/commentsCommentParsing.js
@@ -178,7 +178,7 @@ jsDocMultiLine();
 *New line1
 *New Line2*/
 /** Shoul mege this line as well
-* and this too*//** Another this one too*/
+* and this too*/ /** Another this one too*/
 function jsDocMultiLineMerge() {
 }
 jsDocMultiLineMerge();
@@ -188,23 +188,23 @@ function jsDocMixedComments1() {
 }
 jsDocMixedComments1();
 /// Triple slash comment
-/** jsdoc comment *//*** another jsDocComment*/
+/** jsdoc comment */ /*** another jsDocComment*/
 function jsDocMixedComments2() {
 }
 jsDocMixedComments2();
-/** jsdoc comment *//*** another jsDocComment*/
+/** jsdoc comment */ /*** another jsDocComment*/
 /// Triple slash comment
 function jsDocMixedComments3() {
 }
 jsDocMixedComments3();
-/** jsdoc comment *//*** another jsDocComment*/
+/** jsdoc comment */ /*** another jsDocComment*/
 /// Triple slash comment
 /// Triple slash comment 2
 function jsDocMixedComments4() {
 }
 jsDocMixedComments4();
 /// Triple slash comment 1
-/** jsdoc comment *//*** another jsDocComment*/
+/** jsdoc comment */ /*** another jsDocComment*/
 /// Triple slash comment
 /// Triple slash comment 2
 function jsDocMixedComments5() {
diff --git a/tests/baselines/reference/commentsFunction.js b/tests/baselines/reference/commentsFunction.js
@@ -86,8 +86,8 @@ function blah3(a // trailing commen single line
 ) {
 }
 lambdaFoo = function (a, b) { return a * b; }; // This is trailing comment
-/*leading comment*/(function () { return 0; }); // Needs to be wrapped in parens to be a valid expression (not declaration)
-/*leading comment*/(function () { return 0; }); //trailing comment
+/*leading comment*/ (function () { return 0; }); // Needs to be wrapped in parens to be a valid expression (not declaration)
+/*leading comment*/ (function () { return 0; }); //trailing comment
 function blah4(/*1*/ a /*2*/, /*3*/ b /*4*/) {
 }
 function foo1() {
diff --git a/tests/baselines/reference/commentsOnPropertyOfObjectLiteral1.js b/tests/baselines/reference/commentsOnPropertyOfObjectLiteral1.js
@@ -18,7 +18,7 @@ var resolve = {
     id: /*! @ngInject */ function (details) { return details.id; },
     id1: /* c1 */ "hello",
     id2: 
-    /*! @ngInject */function (details) { return details.id; },
+    /*! @ngInject */ function (details) { return details.id; },
     id3: 
     /*! @ngInject */
     function (details) { return details.id; },
diff --git a/tests/baselines/reference/concatError.js b/tests/baselines/reference/concatError.js
@@ -56,4 +56,4 @@ var c: C<number>;
 var cc: C<C<number>>;
 
 c = c.m(cc);
-*/
+*/ 
diff --git a/tests/baselines/reference/parserSkippedTokens10.js b/tests/baselines/reference/parserSkippedTokens10.js
@@ -5,4 +5,4 @@
 
 
 //// [parserSkippedTokens10.js]
-/*existing trivia*/;
+/*existing trivia*/ ;
diff --git a/tests/baselines/reference/recursivelySpecializedConstructorDeclaration.js b/tests/baselines/reference/recursivelySpecializedConstructorDeclaration.js
@@ -78,4 +78,4 @@ declare module MsPortal.Controls.Base.ItemList {
     class ViewModel<TValue> extends ItemValue<TValue> {
     }
 }
-*/
+*/ 
diff --git a/tests/baselines/reference/scannerS7.4_A2_T2.js b/tests/baselines/reference/scannerS7.4_A2_T2.js
@@ -26,4 +26,4 @@
  */
 /*CHECK#1/
 
-
+ 

Original file line number	Diff line number	Diff line change
`@@ -274,6 +274,9 @@ namespace ts {`
`274`	`274`	`if (hasTrailingNewLine) {`
`275`	`275`	`writer.writeLine();`
`276`	`276`	`}`
	`277`	`+ else if (_kind === SyntaxKind.MultiLineCommentTrivia) {`
	`278`	`+ writer.write(" ");`
	`279`	`+ }`
`277`	`280`	`}`
`278`	`281`
`279`	`282`	`function emitLeadingCommentsOfPosition(pos: number) {`
Original file line number	Diff line number	Diff line change
`@@ -59,4 +59,4 @@ interface B<TBase extends Base> extends A {`
`59`	`59`	`}`
`60`	`60`	`var b: B<Derived> = null;`
`61`	`61`	`var z: Derived = b.foo();`
`62`		`-*/`
	`62`	`+*/`
-Original file line number
+Diff line change
 var x;
 /*
 var bar;
 -*/
 +*/
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ var array = [`
`11`	`11`	`var array = [`
`12`	`12`	`/* element 1*/`
`13`	`13`	`1`
`14`		`- /* end of element 1 */,`
	`14`	`+ /* end of element 1 */ ,`
`15`	`15`	`2`
`16`	`16`	`/* end of element 2 */`
`17`	`17`	`];`
Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,8 @@ var array = [`
`12`	`12`	`var array = [`
`13`	`13`	`/* element 1*/`
`14`	`14`	`1`
`15`		`- /* end of element 1 */,`
	`15`	`+ /* end of element 1 */ ,`
`16`	`16`	`2`
`17`		`- /* end of element 2 */,`
	`17`	`+ /* end of element 2 */ ,`
`18`	`18`	`,`
`19`	`19`	`];`
Original file line number	Diff line number	Diff line change
`@@ -7,5 +7,5 @@ function f() {`
`7`	`7`	`//// [commentOnBlock1.js]`
`8`	`8`	`// asdf`
`9`	`9`	`function f() {`
`10`		`- /asdf/{ }`
	`10`	`+ /asdf/ { }`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,8 @@ function blah3(a // trailing commen single line`
`86`	`86`	`) {`
`87`	`87`	`}`
`88`	`88`	`lambdaFoo = function (a, b) { return a * b; }; // This is trailing comment`
`89`		`-/leading comment/(function () { return 0; }); // Needs to be wrapped in parens to be a valid expression (not declaration)`
`90`		`-/leading comment/(function () { return 0; }); //trailing comment`
	`89`	`+/leading comment/ (function () { return 0; }); // Needs to be wrapped in parens to be a valid expression (not declaration)`
	`90`	`+/leading comment/ (function () { return 0; }); //trailing comment`
`91`	`91`	`function blah4(/1/ a /2/, /3/ b /4/) {`
`92`	`92`	`}`
`93`	`93`	`function foo1() {`