gulp-typescript does handles config extension correctly now (microsoft#16992)

weswigham · web-flow · commit dc81b456e264 · 2017-07-06T15:58:22.000-07:00
diff --git a/Gulpfile.ts b/Gulpfile.ts
@@ -256,14 +256,8 @@ function needsUpdate(source: string | string[], dest: string | string[]): boolea
     return true;
 }
 
-// Doing tsconfig inheritance manually. https://github.com/ivogabe/gulp-typescript/issues/459
-const tsconfigBase = JSON.parse(fs.readFileSync("src/tsconfig-base.json", "utf-8")).compilerOptions;
-
 function getCompilerSettings(base: tsc.Settings, useBuiltCompiler?: boolean): tsc.Settings {
     const copy: tsc.Settings = {};
-    for (const key in tsconfigBase) {
-        copy[key] = tsconfigBase[key];
-    }
     for (const key in base) {
         copy[key] = base[key];
     }

Original file line number	Diff line number	Diff line change
`@@ -256,14 +256,8 @@ function needsUpdate(source: string \| string[], dest: string \| string[]): boolea`
`256`	`256`	`return true;`
`257`	`257`	`}`
`258`	`258`
`259`		`-// Doing tsconfig inheritance manually. https://github.com/ivogabe/gulp-typescript/issues/459`
`260`		`-const tsconfigBase = JSON.parse(fs.readFileSync("src/tsconfig-base.json", "utf-8")).compilerOptions;`
`261`		`-`
`262`	`259`	`function getCompilerSettings(base: tsc.Settings, useBuiltCompiler?: boolean): tsc.Settings {`
`263`	`260`	`const copy: tsc.Settings = {};`
`264`		`- for (const key in tsconfigBase) {`
`265`		`- copy[key] = tsconfigBase[key];`
`266`		`- }`
`267`	`261`	`for (const key in base) {`
`268`	`262`	`copy[key] = base[key];`
`269`	`263`	`}`