Do not report unused errors for module augmentations

mhegazy · mhegazy · commit dc5cf3386182 · 2016-06-29T22:54:18.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -14604,7 +14604,11 @@ namespace ts {
                     if (hasProperty(node.locals, key)) {
                         const local = node.locals[key];
                         if (!local.hasReference && !local.exportSymbol) {
-                            forEach(local.declarations, d => error(d.name, Diagnostics._0_is_declared_but_never_used, local.name));
+                            for (const declaration of local.declarations) {
+                                if (!isAmbientModule(declaration)) {
+                                    error(declaration.name, Diagnostics._0_is_declared_but_never_used, local.name);
+                                }
+                            }
                         }
                     }
                 }
@@ -16487,7 +16491,9 @@ namespace ts {
 
             if (node.body) {
                 checkSourceElement(node.body);
-                checkUnusedIdentifiersDeferred(node);
+                if (!isGlobalScopeAugmentation(node)) {
+                    checkUnusedIdentifiersDeferred(node);
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -14604,7 +14604,11 @@ namespace ts {`
`14604`	`14604`	`if (hasProperty(node.locals, key)) {`
`14605`	`14605`	`const local = node.locals[key];`
`14606`	`14606`	`if (!local.hasReference && !local.exportSymbol) {`
`14607`		`- forEach(local.declarations, d => error(d.name, Diagnostics._0_is_declared_but_never_used, local.name));`
	`14607`	`+ for (const declaration of local.declarations) {`
	`14608`	`+ if (!isAmbientModule(declaration)) {`
	`14609`	`+ error(declaration.name, Diagnostics._0_is_declared_but_never_used, local.name);`
	`14610`	`+ }`
	`14611`	`+ }`
`14608`	`14612`	`}`
`14609`	`14613`	`}`
`14610`	`14614`	`}`
`@@ -16487,7 +16491,9 @@ namespace ts {`
`16487`	`16491`
`16488`	`16492`	`if (node.body) {`
`16489`	`16493`	`checkSourceElement(node.body);`
`16490`		`- checkUnusedIdentifiersDeferred(node);`
	`16494`	`+ if (!isGlobalScopeAugmentation(node)) {`
	`16495`	`+ checkUnusedIdentifiersDeferred(node);`
	`16496`	`+ }`
`16491`	`16497`	`}`
`16492`	`16498`	`}`
`16493`	`16499`