Use union types in the return type of functions in the error case

RyanCavanaugh · RyanCavanaugh · commit da6e82f639a7 · 2016-01-28T11:39:19.000-08:00
Fixes microsoft#6663
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -10390,7 +10390,8 @@ namespace ts {
                     }
                     else {
                         error(func, Diagnostics.No_best_common_type_exists_among_return_expressions);
-                        return unknownType;
+                        // Defer to unioning the return types so we get a) downstream errors earlier and b) better Salsa experience
+                        return getUnionType(types);
                     }
                 }
 
diff --git a/tests/cases/fourslash/getJavaScriptCompletions19.ts b/tests/cases/fourslash/getJavaScriptCompletions19.ts
@@ -0,0 +1,25 @@
+/// <reference path="fourslash.ts" />
+
+// @allowNonTsExtensions: true
+// @Filename: file.js
+//// function fn() {
+//// 	if (foo) {
+//// 		return 0;
+//// 	} else {
+//// 		return '0';
+//// 	}
+//// }
+//// let x = fn();
+//// if(typeof x === 'string') {
+//// 	x/*str*/
+//// } else {
+//// 	x/*num*/
+//// }
+
+goTo.marker('str');
+edit.insert('.');
+verify.completionListContains('substr', undefined, undefined, 'method');
+
+goTo.marker('num');
+edit.insert('.');
+verify.completionListContains('toFixed', undefined, undefined, 'method');

Original file line number	Diff line number	Diff line change
`@@ -10390,7 +10390,8 @@ namespace ts {`
`10390`	`10390`	`}`
`10391`	`10391`	`else {`
`10392`	`10392`	`error(func, Diagnostics.No_best_common_type_exists_among_return_expressions);`
`10393`		`- return unknownType;`
	`10393`	`+ // Defer to unioning the return types so we get a) downstream errors earlier and b) better Salsa experience`
	`10394`	`+ return getUnionType(types);`
`10394`	`10395`	`}`
`10395`	`10396`	`}`
`10396`	`10397`