Use 'filter' array helper (microsoft#20452)

Andy · web-flow · commit d8142339f919 · 2017-12-04T13:36:01.000-08:00
diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts
@@ -711,12 +711,11 @@ namespace ts {
     export function convertEnableAutoDiscoveryToEnable(typeAcquisition: TypeAcquisition): TypeAcquisition {
         // Convert deprecated typingOptions.enableAutoDiscovery to typeAcquisition.enable
         if (typeAcquisition && typeAcquisition.enableAutoDiscovery !== undefined && typeAcquisition.enable === undefined) {
-            const result: TypeAcquisition = {
+            return {
                 enable: typeAcquisition.enableAutoDiscovery,
                 include: typeAcquisition.include || [],
                 exclude: typeAcquisition.exclude || []
             };
-            return result;
         }
         return typeAcquisition;
     }
@@ -1799,9 +1798,8 @@ namespace ts {
         return options;
     }
 
-    function getDefaultTypeAcquisition(configFileName?: string) {
-        const options: TypeAcquisition = { enable: getBaseFileName(configFileName) === "jsconfig.json", include: [], exclude: [] };
-        return options;
+    function getDefaultTypeAcquisition(configFileName?: string): TypeAcquisition {
+        return { enable: getBaseFileName(configFileName) === "jsconfig.json", include: [], exclude: [] };
     }
 
     function convertTypeAcquisitionFromJsonWorker(jsonOptions: any,
diff --git a/src/server/typingsInstaller/typingsInstaller.ts b/src/server/typingsInstaller/typingsInstaller.ts
@@ -205,35 +205,29 @@ namespace ts.server.typingsInstaller {
             this.knownCachesSet.set(cacheLocation, true);
         }
 
-        private filterTypings(typingsToInstall: string[]) {
-            if (typingsToInstall.length === 0) {
-                return typingsToInstall;
-            }
-            const result: string[] = [];
-            for (const typing of typingsToInstall) {
-                if (this.missingTypingsSet.get(typing) || this.packageNameToTypingLocation.get(typing)) {
-                    continue;
+        private filterTypings(typingsToInstall: ReadonlyArray<string>): ReadonlyArray<string> {
+            return typingsToInstall.filter(typing => {
+                if (this.missingTypingsSet.get(typing)) {
+                    if (this.log.isEnabled()) this.log.writeLine(`'${typing}' is in missingTypingsSet - skipping...`);
+                    return false;
                 }
-                const validationResult = JsTyping.validatePackageName(typing);
-                if (validationResult === JsTyping.PackageNameValidationResult.Ok) {
-                    if (this.typesRegistry.has(typing)) {
-                        result.push(typing);
-                    }
-                    else {
-                        if (this.log.isEnabled()) {
-                            this.log.writeLine(`Entry for package '${typing}' does not exist in local types registry - skipping...`);
-                        }
-                    }
+                if (this.packageNameToTypingLocation.get(typing)) {
+                    if (this.log.isEnabled()) this.log.writeLine(`'${typing}' already has a typing - skipping...`);
+                    return false;
                 }
-                else {
+                const validationResult = JsTyping.validatePackageName(typing);
+                if (validationResult !== JsTyping.PackageNameValidationResult.Ok) {
                     // add typing name to missing set so we won't process it again
                     this.missingTypingsSet.set(typing, true);
-                    if (this.log.isEnabled()) {
-                        this.log.writeLine(JsTyping.renderPackageNameValidationFailure(validationResult, typing));
-                    }
+                    if (this.log.isEnabled()) this.log.writeLine(JsTyping.renderPackageNameValidationFailure(validationResult, typing));
+                    return false;
                 }
-            }
-            return result;
+                if (!this.typesRegistry.has(typing)) {
+                    if (this.log.isEnabled()) this.log.writeLine(`Entry for package '${typing}' does not exist in local types registry - skipping...`);
+                    return false;
+                }
+                return true;
+            });
         }
 
         protected ensurePackageDirectoryExists(directory: string) {

Original file line number	Diff line number	Diff line change
`@@ -711,12 +711,11 @@ namespace ts {`
`711`	`711`	`export function convertEnableAutoDiscoveryToEnable(typeAcquisition: TypeAcquisition): TypeAcquisition {`
`712`	`712`	`// Convert deprecated typingOptions.enableAutoDiscovery to typeAcquisition.enable`
`713`	`713`	`if (typeAcquisition && typeAcquisition.enableAutoDiscovery !== undefined && typeAcquisition.enable === undefined) {`
`714`		`- const result: TypeAcquisition = {`
	`714`	`+ return {`
`715`	`715`	`enable: typeAcquisition.enableAutoDiscovery,`
`716`	`716`	`include: typeAcquisition.include \|\| [],`
`717`	`717`	`exclude: typeAcquisition.exclude \|\| []`
`718`	`718`	`};`
`719`		`- return result;`
`720`	`719`	`}`
`721`	`720`	`return typeAcquisition;`
`722`	`721`	`}`
`@@ -1799,9 +1798,8 @@ namespace ts {`
`1799`	`1798`	`return options;`
`1800`	`1799`	`}`
`1801`	`1800`
`1802`		`- function getDefaultTypeAcquisition(configFileName?: string) {`
`1803`		`- const options: TypeAcquisition = { enable: getBaseFileName(configFileName) === "jsconfig.json", include: [], exclude: [] };`
`1804`		`- return options;`
	`1801`	`+ function getDefaultTypeAcquisition(configFileName?: string): TypeAcquisition {`
	`1802`	`+ return { enable: getBaseFileName(configFileName) === "jsconfig.json", include: [], exclude: [] };`
`1805`	`1803`	`}`
`1806`	`1804`
`1807`	`1805`	`function convertTypeAcquisitionFromJsonWorker(jsonOptions: any,`