Code review feedback.

CyrusNajmabadi · CyrusNajmabadi · commit d6fc3fc2daaf · 2014-09-23T15:41:04.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -6544,9 +6544,7 @@ module ts {
                             // If it is a constant value (not undefined), it is syntactically constrained to be a number. 
                             // Also, we do not need to check this for ambients because there is already
                             // a syntax error if it is not a constant.
-                            if (fullTypeCheck) {
-                                checkTypeAssignableTo(checkExpression(initializer), enumType, initializer, /*chainedMessage*/ undefined, /*terminalMessage*/ undefined);
-                            }
+                            checkTypeAssignableTo(checkExpression(initializer), enumType, initializer, /*chainedMessage*/ undefined, /*terminalMessage*/ undefined);
                         }
                     }
                     else if (ambient) {
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -45,6 +45,7 @@ module ts {
         getFlags(): SymbolFlags;
         getName(): string;
         getDeclarations(): Declaration[];
+        getDocumentationComment(): string;
     }
 
     export interface Type {
@@ -222,6 +223,9 @@ module ts {
         flags: SymbolFlags;
         name: string;
         declarations: Declaration[];
+
+        // Undefined is used to indicate the value has not been computed. If, after computing, the
+        // symbol has no doc comment, then the empty string will be returned.
         documentationComment: string;
 
         constructor(flags: SymbolFlags, name: string) {
@@ -2390,7 +2394,7 @@ module ts {
                 return undefined;
             }
 
-            var symbol = <SymbolObject>typeInfoResolver.getSymbolInfo(node);
+            var symbol = typeInfoResolver.getSymbolInfo(node);
             if (!symbol) {
                 return undefined;
             }

Original file line number	Diff line number	Diff line change
`@@ -6544,9 +6544,7 @@ module ts {`
`6544`	`6544`	`// If it is a constant value (not undefined), it is syntactically constrained to be a number.`
`6545`	`6545`	`// Also, we do not need to check this for ambients because there is already`
`6546`	`6546`	`// a syntax error if it is not a constant.`
`6547`		`- if (fullTypeCheck) {`
`6548`		`- checkTypeAssignableTo(checkExpression(initializer), enumType, initializer, /chainedMessage/ undefined, /terminalMessage/ undefined);`
`6549`		`- }`
	`6547`	`+ checkTypeAssignableTo(checkExpression(initializer), enumType, initializer, /chainedMessage/ undefined, /terminalMessage/ undefined);`
`6550`	`6548`	`}`
`6551`	`6549`	`}`
`6552`	`6550`	`else if (ambient) {`