Merge pull request microsoft#11830 from Microsoft/jsDocAV

sheetalkamat · web-flow · commit d54e889cf2e5 · 2016-10-25T10:42:49.000-07:00
Fix the AV resulting from presence of undefined in the jsDocPropertyTags
diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
@@ -6639,12 +6639,16 @@ namespace ts {
                             return true;
                         case "prop":
                         case "property":
-                            if (!parentTag.jsDocPropertyTags) {
-                                parentTag.jsDocPropertyTags = <NodeArray<JSDocPropertyTag>>[];
-                            }
                             const propertyTag = parsePropertyTag(atToken, tagName);
-                            parentTag.jsDocPropertyTags.push(propertyTag);
-                            return true;
+                            if (propertyTag) {
+                                if (!parentTag.jsDocPropertyTags) {
+                                    parentTag.jsDocPropertyTags = <NodeArray<JSDocPropertyTag>>[];
+                                }
+                                parentTag.jsDocPropertyTags.push(propertyTag);
+                                return true;
+                            }
+                            // Error parsing property tag
+                            return false;
                     }
                     return false;
                 }
diff --git a/tests/cases/fourslash/incorrectJsDocObjectLiteralType.ts b/tests/cases/fourslash/incorrectJsDocObjectLiteralType.ts
@@ -0,0 +1,8 @@
+///<reference path="fourslash.ts" />
+
+//// /**/
+
+goTo.marker();
+verify.navigationItemsListCount(0, "foo", "exact");
+edit.insert("/**\n * @typedef {Object} foo\n * @property {any} [obj]\n */\nexport default function foo() {\n}");
+verify.navigationItemsListContains("foo", "function", "foo", "exact");
