Minor PR feedback

rbuckton · rbuckton · commit d4091554cd0d · 2017-12-19T13:50:31.000-08:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -1849,12 +1849,12 @@ namespace ts {
             comparer(a[key], b[key]);
     }
 
-    function getDiagnosticFileName(diagnostic: Diagnostic): string {
+    function getDiagnosticFilePath(diagnostic: Diagnostic): string {
         return diagnostic.file ? diagnostic.file.path : undefined;
     }
 
     export function compareDiagnostics(d1: Diagnostic, d2: Diagnostic): Comparison {
-        return compareStringsCaseSensitive(getDiagnosticFileName(d1), getDiagnosticFileName(d2)) ||
+        return compareStringsCaseSensitive(getDiagnosticFilePath(d1), getDiagnosticFilePath(d2)) ||
             compareValues(d1.start, d2.start) ||
             compareValues(d1.length, d2.length) ||
             compareValues(d1.code, d2.code) ||

Original file line number	Diff line number	Diff line change
`@@ -1849,12 +1849,12 @@ namespace ts {`
`1849`	`1849`	`comparer(a[key], b[key]);`
`1850`	`1850`	`}`
`1851`	`1851`
`1852`		`- function getDiagnosticFileName(diagnostic: Diagnostic): string {`
	`1852`	`+ function getDiagnosticFilePath(diagnostic: Diagnostic): string {`
`1853`	`1853`	`return diagnostic.file ? diagnostic.file.path : undefined;`
`1854`	`1854`	`}`
`1855`	`1855`
`1856`	`1856`	`export function compareDiagnostics(d1: Diagnostic, d2: Diagnostic): Comparison {`
`1857`		`- return compareStringsCaseSensitive(getDiagnosticFileName(d1), getDiagnosticFileName(d2)) \|\|`
	`1857`	`+ return compareStringsCaseSensitive(getDiagnosticFilePath(d1), getDiagnosticFilePath(d2)) \|\|`
`1858`	`1858`	`compareValues(d1.start, d2.start) \|\|`
`1859`	`1859`	`compareValues(d1.length, d2.length) \|\|`
`1860`	`1860`	`compareValues(d1.code, d2.code) \|\|`