Declare 'sum' so that it doesn't require type arguments.

DanielRosenwasser · DanielRosenwasser · commit d25fd23e042b · 2017-07-10T14:35:09.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -83,9 +83,9 @@ namespace ts {
         // extra cost of calling `getParseTreeNode` when calling these functions from inside the
         // checker.
         const checker: TypeChecker = {
-            getNodeCount: () => sum<"nodeCount">(host.getSourceFiles(), "nodeCount"),
-            getIdentifierCount: () => sum<"identifierCount">(host.getSourceFiles(), "identifierCount"),
-            getSymbolCount: () => sum<"symbolCount">(host.getSourceFiles(), "symbolCount") + symbolCount,
+            getNodeCount: () => sum(host.getSourceFiles(), "nodeCount"),
+            getIdentifierCount: () => sum(host.getSourceFiles(), "identifierCount"),
+            getSymbolCount: () => sum(host.getSourceFiles(), "symbolCount") + symbolCount,
             getTypeCount: () => typeCount,
             isUndefinedSymbol: symbol => symbol === undefinedSymbol,
             isArgumentsSymbol: symbol => symbol === argumentsSymbol,
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -700,10 +700,10 @@ namespace ts {
         return result;
     }
 
-    export function sum<K extends string>(array: { [x in K]: number }[], prop: K): number {
+    export function sum<T extends Record<K, number>, K extends string>(array: T[], prop: K): number {
         let result = 0;
         for (const v of array) {
-            result += v[prop];
+            result += (v[prop] as number);
         }
         return result;
     }

Original file line number	Diff line number	Diff line change
`@@ -700,10 +700,10 @@ namespace ts {`
`700`	`700`	`return result;`
`701`	`701`	`}`
`702`	`702`
`703`		`- export function sum<K extends string>(array: { [x in K]: number }[], prop: K): number {`
	`703`	`+ export function sum<T extends Record<K, number>, K extends string>(array: T[], prop: K): number {`
`704`	`704`	`let result = 0;`
`705`	`705`	`for (const v of array) {`
`706`		`- result += v[prop];`
	`706`	`+ result += (v[prop] as number);`
`707`	`707`	`}`
`708`	`708`	`return result;`
`709`	`709`	`}`