Skip to content

Commit d0f669e

Browse files
committed
Merge pull request microsoft#9059 from Microsoft/remove-tsservicesinbrowser
Fix sourcemaps for debugging tests in browser
2 parents 9ffd00d + 88be1ac commit d0f669e

1 file changed

Lines changed: 3 additions & 17 deletions

File tree

Jakefile.js

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,7 @@ function compileFile(outFile, sources, prereqs, prefixes, useBuiltCompiler, opts
313313
}
314314

315315
if (useDebugMode) {
316-
options += " -sourcemap";
317-
if (!opts.noMapRoot) {
318-
options += " -mapRoot file:///" + path.resolve(path.dirname(outFile));
319-
}
316+
options += " --inlineSourceMap --inlineSources";
320317
} else {
321318
options += " --newLine LF";
322319
}
@@ -486,7 +483,6 @@ var tscFile = path.join(builtLocalDirectory, compilerFilename);
486483
compileFile(tscFile, compilerSources, [builtLocalDirectory, copyright].concat(compilerSources), [copyright], /*useBuiltCompiler:*/ false);
487484

488485
var servicesFile = path.join(builtLocalDirectory, "typescriptServices.js");
489-
var servicesFileInBrowserTest = path.join(builtLocalDirectory, "typescriptServicesInBrowserTest.js");
490486
var standaloneDefinitionsFile = path.join(builtLocalDirectory, "typescriptServices.d.ts");
491487
var nodePackageFile = path.join(builtLocalDirectory, "typescript.js");
492488
var nodeDefinitionsFile = path.join(builtLocalDirectory, "typescript.d.ts");
@@ -518,16 +514,6 @@ compileFile(servicesFile, servicesSources,[builtLocalDirectory, copyright].conca
518514
fs.writeFileSync(nodeStandaloneDefinitionsFile, nodeStandaloneDefinitionsFileContents);
519515
});
520516

521-
compileFile(servicesFileInBrowserTest, servicesSources,[builtLocalDirectory, copyright].concat(servicesSources),
522-
/*prefixes*/ [copyright],
523-
/*useBuiltCompiler*/ true,
524-
{ noOutFile: false, generateDeclarations: true, preserveConstEnums: true, keepComments: true, noResolve: false, stripInternal: true, noMapRoot: true },
525-
/*callback*/ function () {
526-
var content = fs.readFileSync(servicesFileInBrowserTest).toString();
527-
var i = content.lastIndexOf("\n");
528-
fs.writeFileSync(servicesFileInBrowserTest, content.substring(0, i) + "\r\n//# sourceURL=../built/local/typeScriptServices.js" + content.substring(i));
529-
});
530-
531517

532518
var serverFile = path.join(builtLocalDirectory, "tsserver.js");
533519
compileFile(serverFile, serverSources,[builtLocalDirectory, copyright].concat(serverSources), /*prefixes*/ [copyright], /*useBuiltCompiler*/ true);
@@ -813,12 +799,12 @@ compileFile(nodeServerOutFile, [nodeServerInFile], [builtLocalDirectory, tscFile
813799

814800
desc("Runs browserify on run.js to produce a file suitable for running tests in the browser");
815801
task("browserify", ["tests", builtLocalDirectory, nodeServerOutFile], function() {
816-
var cmd = 'browserify built/local/run.js -o built/local/bundle.js';
802+
var cmd = 'browserify built/local/run.js -d -o built/local/bundle.js';
817803
exec(cmd);
818804
}, {async: true});
819805

820806
desc("Runs the tests using the built run.js file like 'jake runtests'. Syntax is jake runtests-browser. Additional optional parameters tests=[regex], port=, browser=[chrome|IE]");
821-
task("runtests-browser", ["tests", "browserify", builtLocalDirectory, servicesFileInBrowserTest], function() {
807+
task("runtests-browser", ["tests", "browserify", builtLocalDirectory, servicesFile], function() {
822808
cleanTestDirs();
823809
host = "node";
824810
port = process.env.port || process.env.p || '8888';

0 commit comments

Comments
 (0)