Fix this in harness and improve gulpfile defaults

sandersn · sandersn · commit cf15e825ee01 · 2016-07-11T09:30:58.000-07:00
diff --git a/Gulpfile.ts b/Gulpfile.ts
@@ -306,6 +306,9 @@ function needsUpdate(source: string | string[], dest: string | string[]): boolea
 
 function getCompilerSettings(base: tsc.Settings, useBuiltCompiler?: boolean): tsc.Settings {
     const copy: tsc.Settings = {};
+    // TODO: Add --noImplicitThis --types --pretty when gulp-typescript adds support for them
+    copy.noImplicitAny = true;
+    copy.noEmitOnError = true;
     for (const key in base) {
         copy[key] = base[key];
     }
diff --git a/src/harness/harness.ts b/src/harness/harness.ts
@@ -127,7 +127,7 @@ namespace Utils {
     export function memoize<T extends Function>(f: T): T {
         const cache: { [idx: string]: any } = {};
 
-        return <any>(function() {
+        return <any>(function(this: any) {
             const key = Array.prototype.join.call(arguments);
             const cachedResult = cache[key];
             if (cachedResult) {

Original file line number	Diff line number	Diff line change
`@@ -306,6 +306,9 @@ function needsUpdate(source: string \| string[], dest: string \| string[]): boolea`
`306`	`306`
`307`	`307`	`function getCompilerSettings(base: tsc.Settings, useBuiltCompiler?: boolean): tsc.Settings {`
`308`	`308`	`const copy: tsc.Settings = {};`
	`309`	`+ // TODO: Add --noImplicitThis --types --pretty when gulp-typescript adds support for them`
	`310`	`+ copy.noImplicitAny = true;`
	`311`	`+ copy.noEmitOnError = true;`
`309`	`312`	`for (const key in base) {`
`310`	`313`	`copy[key] = base[key];`
`311`	`314`	`}`