Fixing few code review comments

sheetalkamat · sheetalkamat · commit ce652dc7fbcc · 2015-10-05T12:27:06.000-07:00
diff --git a/src/compiler/commandLineParser.ts b/src/compiler/commandLineParser.ts
@@ -375,9 +375,14 @@ namespace ts {
         }
     }
 
+    /**
+     * Parses non quoted strings separated by comma e.g. "a,b" would result in string array ["a", "b"]
+     * @param s
+     * @param existingValue
+     */
     function parseMultiValueStringArray(s: string, existingValue: string[]) {
         let value: string[] = existingValue || [];
-        let hasError: boolean;
+        let hasError = false;
         let currentString = "";
         if (s) {
             for (let i = 0; i < s.length; i++) {
@@ -480,8 +485,7 @@ namespace ts {
         }
         // Check if the value asked was string[] and value provided was not string[]
         else if (expectedType !== "string[]" ||
-            typeof jsonValue !== "object" ||
-            typeof jsonValue.length !== "number" ||
+            !(jsonValue instanceof Array) ||
             forEach(<string[]>jsonValue, individualValue => typeof individualValue !== "string")) {
             // Not expectedType
             errors.push(createCompilerDiagnostic(Diagnostics.Compiler_option_0_requires_a_value_of_type_1, opt.name, expectedType));
diff --git a/src/compiler/program.ts b/src/compiler/program.ts
@@ -14,10 +14,10 @@ namespace ts {
     
     export const version = "1.7.0";
 
-    export function findConfigFile(searchPath: string, moduleResolutionHost: ModuleResolutionHost): string {
+    export function findConfigFile(searchPath: string, fileExists: (fileName: string) => boolean): string {
         let fileName = "tsconfig.json";
         while (true) {
-            if (moduleResolutionHost.fileExists(fileName)) {
+            if (fileExists(fileName)) {
                 return fileName;
             }
             let parentPath = getDirectoryPath(searchPath);
diff --git a/src/compiler/tsc.ts b/src/compiler/tsc.ts
@@ -188,7 +188,7 @@ namespace ts {
         }
         else if (commandLine.fileNames.length === 0 && isJSONSupported()) {
             let searchPath = normalizePath(sys.getCurrentDirectory());
-            configFileName = findConfigFile(searchPath, sys);
+            configFileName = findConfigFile(searchPath, sys.fileExists);
         }
 
         if (commandLine.fileNames.length === 0 && !configFileName) {
diff --git a/src/harness/projectsRunner.ts b/src/harness/projectsRunner.ts
@@ -195,7 +195,7 @@ class ProjectRunner extends RunnerBase {
                 assert(!inputFiles || inputFiles.length === 0, "cannot specify input files and project option together");
             }
             else if (!inputFiles || inputFiles.length === 0) {
-                configFileName = ts.findConfigFile("", { fileExists, readFile: getSourceFileText });
+                configFileName = ts.findConfigFile("", fileExists);
             }
 
             if (configFileName) {

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ namespace ts {`
`188`	`188`	`}`
`189`	`189`	`else if (commandLine.fileNames.length === 0 && isJSONSupported()) {`
`190`	`190`	`let searchPath = normalizePath(sys.getCurrentDirectory());`
`191`		`- configFileName = findConfigFile(searchPath, sys);`
	`191`	`+ configFileName = findConfigFile(searchPath, sys.fileExists);`
`192`	`192`	`}`
`193`	`193`
`194`	`194`	`if (commandLine.fileNames.length === 0 && !configFileName) {`
Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ class ProjectRunner extends RunnerBase {`
`195`	`195`	`assert(!inputFiles \|\| inputFiles.length === 0, "cannot specify input files and project option together");`
`196`	`196`	`}`
`197`	`197`	`else if (!inputFiles \|\| inputFiles.length === 0) {`
`198`		`- configFileName = ts.findConfigFile("", { fileExists, readFile: getSourceFileText });`
	`198`	`+ configFileName = ts.findConfigFile("", fileExists);`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`if (configFileName) {`