Gracefully handel getChangeRange in Scriptsnapshot.fromString

mhegazy · mhegazy · commit c9b13090252d · 2015-01-16T21:33:53.000-08:00
diff --git a/src/services/services.ts b/src/services/services.ts
@@ -115,7 +115,9 @@ module ts {
             }
 
             public getChangeRange(oldSnapshot: IScriptSnapshot): TextChangeRange {
-                throw new Error("not yet implemented");
+                // Text-based snapshots do not support incremental parsing. Return undefined
+                // to signal that to the caller.
+                return undefined;
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,9 @@ module ts {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`public getChangeRange(oldSnapshot: IScriptSnapshot): TextChangeRange {`
`118`		`- throw new Error("not yet implemented");`
	`118`	`+ // Text-based snapshots do not support incremental parsing. Return undefined`
	`119`	`+ // to signal that to the caller.`
	`120`	`+ return undefined;`
`119`	`121`	`}`
`120`	`122`	`}`
`121`	`123`