Remove dependncy on NodeJs from editor services

mhegazy · mhegazy · commit c884fee3eb5b · 2016-05-19T13:16:20.000-07:00
diff --git a/src/harness/harnessLanguageService.ts b/src/harness/harnessLanguageService.ts
@@ -641,6 +641,14 @@ namespace Harness.LanguageService {
 
         startGroup(): void {
         }
+
+        setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any {
+            return setTimeout(callback, ms, args);
+        }
+
+        clearTimeout(timeoutId: any): void {
+            clearTimeout(timeoutId);
+        }
     }
 
     export class ServerLanguageServiceAdapter implements LanguageServiceAdapter {
diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts
@@ -533,7 +533,7 @@ namespace ts.server {
         // number becomes 0 for a watcher, then we should close it.
         directoryWatchersRefCount: ts.Map<number> = {};
         hostConfiguration: HostConfiguration;
-        timerForDetectingProjectFileListChanges: Map<NodeJS.Timer> = {};
+        timerForDetectingProjectFileListChanges: Map<any> = {};
 
         constructor(public host: ServerHost, public psLogger: Logger, public eventHandler?: ProjectServiceEventHandler) {
             // ts.disableIncrementalParsing = true;
@@ -593,9 +593,9 @@ namespace ts.server {
 
         startTimerForDetectingProjectFileListChanges(project: Project) {
             if (this.timerForDetectingProjectFileListChanges[project.projectFilename]) {
-                clearTimeout(this.timerForDetectingProjectFileListChanges[project.projectFilename]);
+                this.host.clearTimeout(this.timerForDetectingProjectFileListChanges[project.projectFilename]);
             }
-            this.timerForDetectingProjectFileListChanges[project.projectFilename] = setTimeout(
+            this.timerForDetectingProjectFileListChanges[project.projectFilename] = this.host.setTimeout(
                 () => this.handleProjectFileListChanges(project),
                 250
             );
diff --git a/src/server/server.ts b/src/server/server.ts
@@ -266,16 +266,21 @@ namespace ts.server {
         }
     }
 
+    const sys = <ServerHost>ts.sys;
+
     // Override sys.write because fs.writeSync is not reliable on Node 4
-    ts.sys.write = (s: string) => writeMessage(s);
-    ts.sys.watchFile = (fileName, callback) => {
+    sys.write = (s: string) => writeMessage(s);
+    sys.watchFile = (fileName, callback) => {
         const watchedFile = pollingWatchedFileSet.addFile(fileName, callback);
         return {
             close: () => pollingWatchedFileSet.removeFile(watchedFile)
         };
     };
 
-    const ioSession = new IOSession(ts.sys, logger);
+    sys.setTimeout = setTimeout;
+    sys.clearTimeout = clearTimeout;
+
+    const ioSession = new IOSession(sys, logger);
     process.on("uncaughtException", function(err: Error) {
         ioSession.logError(err, "unknown");
     });
diff --git a/src/server/session.ts b/src/server/session.ts
@@ -133,6 +133,8 @@ namespace ts.server {
     }
 
     export interface ServerHost extends ts.System {
+        setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any;
+        clearTimeout(timeoutId: any): void;
     }
 
     export class Session {
diff --git a/tests/cases/unittests/cachingInServerLSHost.ts b/tests/cases/unittests/cachingInServerLSHost.ts
@@ -60,6 +60,12 @@ module ts {
                 return {
                     close: () => { }
                 }
+            },
+            setTimeout: (callback, ms, ...args) => {
+                return setTimeout(callback, ms, args);
+            },
+            clearTimeout: (timeoutId) => {
+                clearTimeout(timeoutId);
             }
         };
     }
diff --git a/tests/cases/unittests/session.ts b/tests/cases/unittests/session.ts
@@ -18,7 +18,9 @@ namespace ts.server {
         getExecutingFilePath(): string { return void 0; },
         getCurrentDirectory(): string { return void 0; },
         readDirectory(): string[] { return []; },
-        exit(): void {}
+        exit(): void { },
+        setTimeout(callback, ms, ...args) { return 0; },
+        clearTimeout(timeoutId) { }
     };
     const mockLogger: Logger = {
         close(): void {},
diff --git a/tests/cases/unittests/versionCache.ts b/tests/cases/unittests/versionCache.ts
@@ -271,7 +271,7 @@ and grew 1cm per day`;
         });
 
         it("Edit ScriptVersionCache ", () => {
-            let svc = server.ScriptVersionCache.fromString(ts.sys, testContent);
+            let svc = server.ScriptVersionCache.fromString(<server.ServerHost>ts.sys, testContent);
             let checkText = testContent;
 
             for (let i = 0; i < iterationCount; i++) {

Original file line number	Diff line number	Diff line change
`@@ -641,6 +641,14 @@ namespace Harness.LanguageService {`
`641`	`641`
`642`	`642`	`startGroup(): void {`
`643`	`643`	`}`
	`644`	`+`
	`645`	`+ setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any {`
	`646`	`+ return setTimeout(callback, ms, args);`
	`647`	`+ }`
	`648`	`+`
	`649`	`+ clearTimeout(timeoutId: any): void {`
	`650`	`+ clearTimeout(timeoutId);`
	`651`	`+ }`
`644`	`652`	`}`
`645`	`653`
`646`	`654`	`export class ServerLanguageServiceAdapter implements LanguageServiceAdapter {`
Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,8 @@ namespace ts.server {`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`export interface ServerHost extends ts.System {`
	`136`	`+ setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any;`
	`137`	`+ clearTimeout(timeoutId: any): void;`
`136`	`138`	`}`
`137`	`139`
`138`	`140`	`export class Session {`
Original file line number	Diff line number	Diff line change
`@@ -60,6 +60,12 @@ module ts {`
`60`	`60`	`return {`
`61`	`61`	`close: () => { }`
`62`	`62`	`}`
	`63`	`+ },`
	`64`	`+ setTimeout: (callback, ms, ...args) => {`
	`65`	`+ return setTimeout(callback, ms, args);`
	`66`	`+ },`
	`67`	`+ clearTimeout: (timeoutId) => {`
	`68`	`+ clearTimeout(timeoutId);`
`63`	`69`	`}`
`64`	`70`	`};`
`65`	`71`	`}`