getSupportedExtensions optimization to reduce allocations

jramsay · jramsay · commit c40508cf1cbe · 2016-12-09T16:25:09.000-08:00
diff --git a/src/compiler/core.ts b/src/compiler/core.ts
@@ -1925,15 +1925,17 @@ namespace ts {
     const allSupportedExtensions = supportedTypeScriptExtensions.concat(supportedJavascriptExtensions);
 
     export function getSupportedExtensions(options?: CompilerOptions, extraFileExtensions?: FileExtensionInfo[]): string[] {
-        let typeScriptHostExtensions: string[] = [];
-        let allHostExtensions: string[] = [];
-        if (extraFileExtensions) {
-            allHostExtensions = ts.map(extraFileExtensions, item => item.extension);
-            typeScriptHostExtensions = ts.map(ts.filter(extraFileExtensions, item => item.scriptKind === ScriptKind.TS), item => item.extension);
-        }
-        const allTypeScriptExtensions = concatenate(supportedTypeScriptExtensions, typeScriptHostExtensions);
-        const allExtensions = concatenate(allSupportedExtensions, allHostExtensions);
-        return options && options.allowJs ? allExtensions : allTypeScriptExtensions;
+        const needAllExtensions = options && options.allowJs;
+        if (!extraFileExtensions || extraFileExtensions.length === 0) {
+            return needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions;
+        }
+        const extensions = (needAllExtensions ? allSupportedExtensions : supportedTypeScriptExtensions).slice(0);
+        for (const extInfo of extraFileExtensions) {
+            if (needAllExtensions || extInfo.scriptKind === ScriptKind.TS) {
+                extensions.push(extInfo.extension);
+            }
+        }
+        return extensions;
     }
 
     export function hasJavaScriptFileExtension(fileName: string) {
