Don't provide string literal completions for string enums (microsoft#18288)

Andy · web-flow · commit be0633825cd4 · 2017-09-07T09:13:46.000-07:00
* Don't provide string literal completions for string enums

* Rename test
diff --git a/src/services/completions.ts b/src/services/completions.ts
@@ -284,7 +284,7 @@ namespace ts.Completions {
                 addStringLiteralCompletionsFromType(t, result, typeChecker, uniques);
             }
         }
-        else if (type.flags & TypeFlags.StringLiteral) {
+        else if (type.flags & TypeFlags.StringLiteral && !(type.flags & TypeFlags.EnumLiteral)) {
             const name = (<StringLiteralType>type).value;
             if (!uniques.has(name)) {
                 uniques.set(name, true);
diff --git a/tests/cases/fourslash/stringLiteralCompletionsForStringEnumContextualType.ts b/tests/cases/fourslash/stringLiteralCompletionsForStringEnumContextualType.ts
@@ -0,0 +1,9 @@
+/// <reference path="fourslash.ts" />
+
+////const enum E {
+////    A = "A",
+////}
+////const e: E = "/**/";
+
+goTo.marker("");
+verify.completionListIsEmpty();

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ namespace ts.Completions {`
`284`	`284`	`addStringLiteralCompletionsFromType(t, result, typeChecker, uniques);`
`285`	`285`	`}`
`286`	`286`	`}`
`287`		`- else if (type.flags & TypeFlags.StringLiteral) {`
	`287`	`+ else if (type.flags & TypeFlags.StringLiteral && !(type.flags & TypeFlags.EnumLiteral)) {`
`288`	`288`	`const name = (<StringLiteralType>type).value;`
`289`	`289`	`if (!uniques.has(name)) {`
`290`	`290`	`uniques.set(name, true);`